From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA9AC433E1 for ; Tue, 25 Aug 2020 08:19:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24CDF2071E for ; Tue, 25 Aug 2020 08:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728821AbgHYITk (ORCPT ); Tue, 25 Aug 2020 04:19:40 -0400 Received: from mga01.intel.com ([192.55.52.88]:52905 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728080AbgHYITj (ORCPT ); Tue, 25 Aug 2020 04:19:39 -0400 IronPort-SDR: do3N9EIsd6ZK3JHn6ss/p2E9zqwYJpxXjSSZNI3w9bSslftRgOMFqeC17WJnt7S+9Idyr2C14g aAbHx0ED4lyw== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="174105425" X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="174105425" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 01:19:39 -0700 IronPort-SDR: IAyy3XvyJQ+SAT+IwGXbxMgmsJ1zhfw2TY4/QER4Co/2ItAYsuTyCJU8mYDU6OdgbX3Cth9jyR XFHHFRaYByzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="402642901" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 25 Aug 2020 01:19:36 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 25 Aug 2020 11:19:35 +0300 Date: Tue, 25 Aug 2020 11:19:35 +0300 From: Heikki Krogerus To: "Ramuthevar, Vadivel MuruganX" Cc: Andy Shevchenko , Andy Shevchenko , Linux Kernel Mailing List , MyungJoo Ham , Chanwoo Choi , thomas.langer@intel.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com, yin1.li@intel.com Subject: Re: [PATCH v1 0/9] extcon: extcon-ptn5150: Add the USB external connector support Message-ID: <20200825081935.GE189773@kuha.fi.intel.com> References: <20200818065727.50520-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200818084044.GD1891694@smile.fi.intel.com> <69e13a74-8b8d-cbc0-915d-ce289e7d4a70@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote: > Hi Andy, > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote: > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX > > wrote: > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote: > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote: > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC > > > > > boards to detect the USB type and connection. > > > > Internally I meant you can send cleanups, but couple of patches here are the > > > > features and were still under discussion... But here we are. > > > > > > you mean asking us to implement the Heikki suggested as below.. > > > > > > Heikki Krogerus: register the port and the partner attached to it with > > > the USB Type-C connector class in the driver. Is my understaanding > > > right? if not, please explain it. Thanks! > > > > When you mention somebody, don't forget to Cc them (now done by me). > Sure, Thank you So the patches 1-5 are fine. The rest needs to be rewritten. thanks, -- heikki