Re: [PATCH 0/9] introduce name service announcement rpmsg driver

Mathieu Poirier
2020-08-20T22:32:46Z

On Fri, Jul 31, 2020 at 01:47:23PM +0200, Arnaud Pouliquen wrote:
> The NS announcement is implemented by several backends, but could be
> considered as part the RPMsg protocol.
> In this case it should be managed as a reserved rpmsg service and so
> implemented on top of the rpmsg protocol.
>
> This series introduces the rpmsg_ns driver that handles the name service
> announcement. The virtio backend is updated in consequence to use this
> service.

I have started to review this set, comments will be spread over a few days.

Thanks,
Mathieu

>
> Applies cleanly on Bjorn rpmsg-next branch (ddd1930d6e3e)
>
> Arnaud Pouliquen (9):
> rpmsg: virtio: rename rpmsg_create_channel
> rpmsg: core: add channel creation internal API
> rpmsg: virtio: add rpmsg channel device ops
> rpmsg: define the name service announcement as reserved address
> rpmsg: introduce reserved rpmsg driver for ns announcement
> rpmsg: virtio: use rpmsg ns device for the ns announcement
> rpmsg: ns: add name service announcement service
> rpmsg: virtio: use rpmsg_ns driver to manage ns announcement
> rpmsg: ns: name service announcement endianness
>
> drivers/rpmsg/Kconfig | 9 ++
> drivers/rpmsg/Makefile | 1 +
> drivers/rpmsg/rpmsg_core.c | 37 ++++++
> drivers/rpmsg/rpmsg_internal.h | 32 +++++
> drivers/rpmsg/rpmsg_ns.c | 175 +++++++++++++++++++++++++
> drivers/rpmsg/virtio_rpmsg_bus.c | 213 +++++++++----------------------
> include/linux/rpmsg.h | 9 ++
> 7 files changed, 325 insertions(+), 151 deletions(-)
> create mode 100644 drivers/rpmsg/rpmsg_ns.c
>
> --
> 2.17.1
>