Re: [PATCH 2/3] ARM: dts: Add ethernet

Krzysztof Kozlowski
2020-08-25T18:49:25Z

On Tue, Aug 25, 2020 at 07:03:10PM +0200, Łukasz Stelmach wrote:
> Add node for ax88796c ethernet chip.

Subject
ARM: dts: exynos: Add Ethernet to Artik 5 board

>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 ++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> index 20446a846a98..44151a2cb35d 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> @@ -37,3 +37,24 @@ &mshc_2 {
> &serial_2 {
> status = "okay";
> };
> +
> +&spi_0 {
> + status = "okay";
> + cs-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>, <0>;
> +
> + assigned-clocks = <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>, <&cmu CLK_SCLK_SPI0>;
> + assigned-clock-parents = <&cmu CLK_FOUT_MPLL>, <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>;
> +
> + ax88796c@0 {
> + compatible = "asix,ax88796c";

Isn't checkpatch complaining about undocumented compatible? I didn't see
a binding here.

> + interrupt-parent = <&gpx2>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + spi-max-frequency = <40000000>;
> + reg = <0x0>;
> + reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>;

One line break.

> + controller-data {
> + samsung,spi-feedback-delay = <2>;
> + samsung,spi-chip-select-mode;

What does samsung,spi-chip-select-mode mean? git grep does not find a binding.

> + };
> + };

Whatever formatting you used here, it is not Linux coding style. Please
fix indentation, linewrapping.

Best regards,
Krzysztof