From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Jeykumar Sankaran <jsanka@codeaurora.org>,
Chandan Uddaraju <chandanu@codeaurora.org>,
Vara Reddy <varar@codeaurora.org>,
Tanmay Shah <tanmay@codeaurora.org>,
Manu Gautam <mgautam@codeaurora.org>,
Sandeep Maheswaram <sanm@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
Jonathan Marek <jonathan@marek.ca>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@chromium.org>
Subject: Re: [PATCH v1 3/9] phy: qcom-qmp: Remove 'initialized' in favor of 'init_count'
Date: Tue, 25 Aug 2020 22:44:46 -0500 [thread overview]
Message-ID: <20200826034446.GE3715@yoga> (raw)
In-Reply-To: <20200826024711.220080-4-swboyd@chromium.org>
On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote:
> We already track if any phy inside the qmp wrapper has been initialized
> by means of the struct qcom_qmp::init_count member. Let's drop the
> duplicate 'initialized' member to simplify the code a bit.
>
> Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
> Cc: Chandan Uddaraju <chandanu@codeaurora.org>
> Cc: Vara Reddy <varar@codeaurora.org>
> Cc: Tanmay Shah <tanmay@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Cc: Manu Gautam <mgautam@codeaurora.org>
> Cc: Sandeep Maheswaram <sanm@codeaurora.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Jonathan Marek <jonathan@marek.ca>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Rob Clark <robdclark@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 7ee9e966dc6d..4a23ba9361b3 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -1844,7 +1844,6 @@ struct qmp_phy {
> * @phys: array of per-lane phy descriptors
> * @phy_mutex: mutex lock for PHY common block initialization
> * @init_count: phy common block initialization count
> - * @phy_initialized: indicate if PHY has been initialized
> * @ufs_reset: optional UFS PHY reset handle
> */
> struct qcom_qmp {
> @@ -1861,7 +1860,6 @@ struct qcom_qmp {
>
> struct mutex phy_mutex;
> int init_count;
> - bool phy_initialized;
>
> struct reset_control *ufs_reset;
> };
> @@ -2748,7 +2746,6 @@ static int qcom_qmp_phy_enable(struct phy *phy)
> dev_err(qmp->dev, "phy initialization timed-out\n");
> goto err_pcs_ready;
> }
> - qmp->phy_initialized = true;
> return 0;
>
> err_pcs_ready:
> @@ -2792,8 +2789,6 @@ static int qcom_qmp_phy_disable(struct phy *phy)
>
> qcom_qmp_phy_com_exit(qmp);
>
> - qmp->phy_initialized = false;
> -
> return 0;
> }
>
> @@ -2868,7 +2863,7 @@ static int __maybe_unused qcom_qmp_phy_runtime_suspend(struct device *dev)
> if (cfg->type != PHY_TYPE_USB3)
> return 0;
>
> - if (!qmp->phy_initialized) {
> + if (!qmp->init_count) {
> dev_vdbg(dev, "PHY not initialized, bailing out\n");
> return 0;
> }
> @@ -2894,7 +2889,7 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev)
> if (cfg->type != PHY_TYPE_USB3)
> return 0;
>
> - if (!qmp->phy_initialized) {
> + if (!qmp->init_count) {
> dev_vdbg(dev, "PHY not initialized, bailing out\n");
> return 0;
> }
> --
> Sent by a computer, using git, on the internet
>
next prev parent reply other threads:[~2020-08-26 3:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 2:47 [PATCH v1 0/9] Support qcom USB3+DP combo phy (or type-c phy) Stephen Boyd
2020-08-26 2:47 ` [PATCH v1 1/9] dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information Stephen Boyd
2020-08-26 2:47 ` [PATCH v1 2/9] phy: qcom-qmp: Move phy mode into struct qmp_phy Stephen Boyd
2020-08-26 3:37 ` Bjorn Andersson
2020-08-26 2:47 ` [PATCH v1 3/9] phy: qcom-qmp: Remove 'initialized' in favor of 'init_count' Stephen Boyd
2020-08-26 3:44 ` Bjorn Andersson [this message]
2020-08-26 2:47 ` [PATCH v1 4/9] phy: qcom-qmp: Move 'serdes' and 'cfg' into 'struct qcom_phy' Stephen Boyd
2020-08-26 2:47 ` [PATCH v1 5/9] phy: qcom-qmp: Get dp_com I/O resource by index Stephen Boyd
2020-08-26 4:36 ` Bjorn Andersson
2020-08-26 21:32 ` Stephen Boyd
2020-08-27 1:59 ` Bjorn Andersson
2020-08-26 2:47 ` [PATCH v1 6/9] phy: qcom-qmp: Add support for DP in USB3+DP combo phy Stephen Boyd
2020-09-01 13:36 ` Dmitry Baryshkov
2020-09-02 1:01 ` Stephen Boyd
2020-09-03 12:37 ` Dmitry Baryshkov
2020-09-03 12:41 ` Jonathan Marek
2020-09-03 21:35 ` Dmitry Baryshkov
2020-09-03 22:55 ` Stephen Boyd
2020-08-26 2:47 ` [PATCH v1 7/9] phy: qcom-qmp: Add support for sc7180 DP phy Stephen Boyd
2020-08-26 2:47 ` [PATCH v1 8/9] clk: qcom: dispcc: Update DP clk ops for phy design Stephen Boyd
2020-08-26 2:47 ` [PATCH v1 9/9] drm/msm/dp: Use qmp phy for DP PLL and PHY Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826034446.GE3715@yoga \
--to=bjorn.andersson@linaro.org \
--cc=chandanu@codeaurora.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=jsanka@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=sanm@codeaurora.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
--cc=varar@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox