Re: [PATCH v1 3/9] extcon: extcon-ptn5150: Switch to BIT() macro for cable attach

Krzysztof Kozlowski
2020-08-26T06:59:48Z

On Tue, Aug 18, 2020 at 02:57:21PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> Switch to BIT() macro for the cable attach.

Squash it.

>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
> ---
> drivers/extcon/extcon-ptn5150.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
> index c816a6c1e05c..fab862d9aad8 100644
> --- a/drivers/extcon/extcon-ptn5150.c
> +++ b/drivers/extcon/extcon-ptn5150.c
> @@ -44,9 +44,7 @@ enum ptn5150_reg {
>
> #define PTN5150_REG_CC_VBUS_DETECTION BIT(7)
>
> -#define PTN5150_REG_INT_CABLE_ATTACH_SHIFT 0
> -#define PTN5150_REG_INT_CABLE_ATTACH_MASK \
> - (0x1 << PTN5150_REG_INT_CABLE_ATTACH_SHIFT)
> +#define PTN5150_REG_INT_CABLE_ATTACH_MASK BIT(0)
>
> #define PTN5150_REG_INT_CABLE_DETACH_SHIFT 1
> #define PTN5150_REG_INT_CABLE_DETACH_MASK \
> --
> 2.11.0
>