From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Subject: Re: [PATCH v1] extcon: ptn5150: Deduplicate parts of dev_err_probe()
Date: Wed, 26 Aug 2020 14:24:11 +0200 [thread overview]
Message-ID: <20200826122411.GA12977@pi3> (raw)
In-Reply-To: <20200826103910.81413-1-andriy.shevchenko@linux.intel.com>
On Wed, Aug 26, 2020 at 01:39:10PM +0300, Andy Shevchenko wrote:
> dev_err_probe() is designed to be used like
>
> return dev_err_probe(dev, ret, "Error message\n");
>
> Hence no need to have a separate return statement. Besides that
> dev_err_probe() prints already returned error code, no need to repeat
> that either.
>
> Fixes: 48cbf8c6653c ("extcon: ptn5150: Reduce the amount of logs on deferred probe")
It's an code improvement, optimization, but there is no error here to
fix and Fixes tag would trigger backporting to stable. This patch
should not be backported because it does not meet the backporting
requirements.
With Fixes removed:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2020-08-26 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 10:39 [PATCH v1] extcon: ptn5150: Deduplicate parts of dev_err_probe() Andy Shevchenko
2020-08-26 12:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826122411.GA12977@pi3 \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=vijaikumar.kanagarajan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox