From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E77B3C433DF for ; Wed, 26 Aug 2020 12:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC0CD20897 for ; Wed, 26 Aug 2020 12:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598444906; bh=94vf/goBzfoC5nm9rDlXYfi2mPg0KiLVJ1zsM82yLYE=; h=From:To:Cc:Subject:Date:List-ID:From; b=EqvefSBkAYtv6KaDZuez3OW7nlMx2iiXvpdNXqvC9P0sxvjUpNDltq5myWR2x3SlT Pjbs9C6XVfeQq9U+zDGcDmJdSyTRRb2MVqQEap8wXNujlajYDB4bC7K4fpzSkCtTbq 0hLEujdkcPnbiB0ofJdwHS/+lLv9/rDX6jUgu118= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729654AbgHZM2Z (ORCPT ); Wed, 26 Aug 2020 08:28:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:60512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729369AbgHZM2X (ORCPT ); Wed, 26 Aug 2020 08:28:23 -0400 Received: from localhost.localdomain (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 222042080C; Wed, 26 Aug 2020 12:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598444903; bh=94vf/goBzfoC5nm9rDlXYfi2mPg0KiLVJ1zsM82yLYE=; h=From:To:Cc:Subject:Date:From; b=skoJy6gPAskSS9qnDxXxdhst6jKjvkpOu2bECZju2/2wNKRzkdhCbAtKV6Zt9Jy2K f+cXA/NK1p/XX5uNDNegefnQZn8jm7mG2L9l8i8NtLVHfetMxbME5pNI5W8S6Mm3HQ CzGr4x6AtST8oRwp9z27pQSDvnbI1sOkbQNamw48= From: Vinod Koul To: Mark Brown Cc: Vinod Koul , Takashi Iwai , Pierre-Louis Bossart , Ryan Lee , Kai Vehmanen , Rander Wang , Naveen Manohar , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai Subject: [PATCH 1/4] ASoC: max98373: Fix return check for devm_regmap_init_sdw() Date: Wed, 26 Aug 2020 17:58:08 +0530 Message-Id: <20200826122811.3223663-1-vkoul@kernel.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 56a5b7910e96 ("ASoC: codecs: max98373: add SoundWire support") Signed-off-by: Vinod Koul --- sound/soc/codecs/max98373-sdw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c index 5fe724728e84..e4675cfff7b2 100644 --- a/sound/soc/codecs/max98373-sdw.c +++ b/sound/soc/codecs/max98373-sdw.c @@ -838,8 +838,8 @@ static int max98373_sdw_probe(struct sdw_slave *slave, /* Regmap Initialization */ regmap = devm_regmap_init_sdw(slave, &max98373_sdw_regmap); - if (!regmap) - return -EINVAL; + if (IS_ERR(regmap)) + return PTR_ERR(regmap); return max98373_init(slave, regmap); } -- 2.26.2