Re: [PATCH 08/24] Input: elan_i2c - Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T09:09:30Z

On Wed, Aug 26, 2020 at 9:20 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/input/mouse/elan_i2c_core.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index c599e21a8478..d703b0d5a3bd 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -1229,13 +1229,8 @@ static int elan_probe(struct i2c_client *client,
> mutex_init(&data->sysfs_mutex);
>
> data->vcc = devm_regulator_get(dev, "vcc");
> - if (IS_ERR(data->vcc)) {
> - error = PTR_ERR(data->vcc);
> - if (error != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get 'vcc' regulator: %d\n",
> - error);
> - return error;
> - }
> + if (IS_ERR(data->vcc))
> + return dev_err_probe(dev, PTR_ERR(data->vcc), "Failed to get 'vcc' regulator\n");
>
> error = regulator_enable(data->vcc);
> if (error) {
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko