Re: [PATCH 09/24] Input: bu21013_ts - Simplify with dev_err_probe()

Krzysztof Kozlowski
2020-08-27T18:41:46Z

On Thu, Aug 27, 2020 at 12:10:38PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 26, 2020 at 9:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > Common pattern of handling deferred probe can be simplified with
> > dev_err_probe(). Less code and also it prints the error value.
>
> > ts->cs_gpiod = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
> > error = PTR_ERR_OR_ZERO(ts->cs_gpiod);
>
> > + if (error)
> > + return dev_err_probe(&client->dev, error, "failed to get CS GPIO\n");
> > +
>
> if (IS_ERR())
> return ... PTR_ERR()...

Indeed.

Best regards,
Krzysztof