Re: [PATCH 12/24] Input: cy8ctma140 - Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T09:12:12Z

On Wed, Aug 26, 2020 at 9:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/input/touchscreen/cy8ctma140.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/input/touchscreen/cy8ctma140.c b/drivers/input/touchscreen/cy8ctma140.c
> index a9be29139cbf..23da5bb00ead 100644
> --- a/drivers/input/touchscreen/cy8ctma140.c
> +++ b/drivers/input/touchscreen/cy8ctma140.c
> @@ -259,12 +259,8 @@ static int cy8ctma140_probe(struct i2c_client *client,
> ts->regulators[1].supply = "vdd";
> error = devm_regulator_bulk_get(dev, ARRAY_SIZE(ts->regulators),
> ts->regulators);
> - if (error) {
> - if (error != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get regulators %d\n",
> - error);
> - return error;
> - }
> + if (error)
> + return dev_err_probe(dev, error, "Failed to get regulators\n");
>
> error = cy8ctma140_power_up(ts);
> if (error)
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko