Re: [PATCH 13/24] Input: edf-ft5x06 - Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T09:12:29Z

On Wed, Aug 26, 2020 at 9:21 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/input/touchscreen/edt-ft5x06.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index 6ff81d48da86..d4827ac963b0 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -1098,13 +1098,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
> tsdata->max_support_points = chip_data->max_support_points;
>
> tsdata->vcc = devm_regulator_get(&client->dev, "vcc");
> - if (IS_ERR(tsdata->vcc)) {
> - error = PTR_ERR(tsdata->vcc);
> - if (error != -EPROBE_DEFER)
> - dev_err(&client->dev,
> - "failed to request regulator: %d\n", error);
> - return error;
> - }
> + if (IS_ERR(tsdata->vcc))
> + return dev_err_probe(&client->dev, PTR_ERR(tsdata->vcc),
> + "failed to request regulator\n");
>
> error = regulator_enable(tsdata->vcc);
> if (error < 0) {
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko