Re: [PATCH 01/24] Input: bcm-keypad - Simplify with dev_err_probe()

Hans de Goede
2020-08-26T19:57:56Z

Hi,

As someone who has added the if (error != -EPROBE_DEFER) dev_err()
pattern in way too many places myself, I'm quite happy to see this
new (I presume?) helper and this nice cleanup series.

The entire series looks good to me, and you can add my:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

To the entire series.

Regards,

Hans

On 8/26/20 8:16 PM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/input/keyboard/bcm-keypad.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
> index 2b771c3a5578..1bf71e7c9e0d 100644
> --- a/drivers/input/keyboard/bcm-keypad.c
> +++ b/drivers/input/keyboard/bcm-keypad.c
> @@ -379,11 +379,9 @@ static int bcm_kp_probe(struct platform_device *pdev)
> kp->clk = devm_clk_get(&pdev->dev, "peri_clk");
> if (IS_ERR(kp->clk)) {
> error = PTR_ERR(kp->clk);
> - if (error != -ENOENT) {
> - if (error != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Failed to get clock\n");
> - return error;
> - }
> + if (error != -ENOENT)
> + return dev_err_probe(&pdev->dev, error, "Failed to get clock\n");
> +
> dev_dbg(&pdev->dev,
> "No clock specified. Assuming it's enabled\n");
> kp->clk = NULL;
>