From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5FDC433E1 for ; Wed, 26 Aug 2020 19:13:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47476207BC for ; Wed, 26 Aug 2020 19:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598469193; bh=AE8WdGpJPbWaT/Lz0OQ6sCivaAFfLcL5G+HUYMNndH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0llz4AM6Soc9tqmv262cvq3gaIkVoD/3ERVDtzdc8e12pfyK8d6OK/0rm0bPu3QYf k9Deb2OxBo0cL0k2jyJOrnGxMZIiQaSOkkXT/t1dtFiSuuuQS708LQ7YGo/MWpS26L cdJBxBTfUk/5FrjkvgWHKiRNuy9z3cUC0WJJbSvE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbgHZTNJ (ORCPT ); Wed, 26 Aug 2020 15:13:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:37176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgHZTNA (ORCPT ); Wed, 26 Aug 2020 15:13:00 -0400 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BABDF207BC; Wed, 26 Aug 2020 19:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598469179; bh=AE8WdGpJPbWaT/Lz0OQ6sCivaAFfLcL5G+HUYMNndH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cyj6dxspCv8rogcCDSzXgfwWVul6bJpc3LnfQB7CHJ4CMDxBASbHcZtfaAtzjjhgt s4Yb4w+dAeOTQG8kYdQQ4VNxfvEaHrNmPylfwhhpCw5QxN2PqtuhmHmFrft53FtKcw wVuQDLZ0BZ458wjjKZYVMny/AkV9anY4rKYCrRJ8= Date: Wed, 26 Aug 2020 14:18:59 -0500 From: "Gustavo A. R. Silva" To: Alex Dewar Cc: dennis.dalessandro@intel.com, dledford@redhat.com, gustavo@embeddedor.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, mike.marciniszyn@intel.com, roland@purestorage.com Subject: Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements Message-ID: <20200826191859.GB2671@embeddedor> References: <64d7e1c9-9c6a-93f3-ce0a-c24b1c236071@gmail.com> <20200825171242.448447-1-alex.dewar90@gmail.com> <20200825193327.GA5504@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825193327.GA5504@embeddedor> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote: > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > > were later converted to fallthrough statements by commit df561f6688fe > > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity > > warning about unreachable code. > > > > It's worth mentioning that this warning is triggered only by compilers > that don't support __attribute__((__fallthrough__)), which has been > supported since GCC 7.1. > > > Remove the fallthrough statements. > > > > Addresses-Coverity: ("Unreachable code") > > Fixes: 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > Signed-off-by: Alex Dewar > > Reviewed-by: Gustavo A. R. Silva > I can take this in my tree for 5.9-rc3. Thanks -- Gustavo