From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52FDC433DF for ; Thu, 27 Aug 2020 01:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0FFC207F7 for ; Thu, 27 Aug 2020 01:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598492122; bh=7qVVxVRgHLIAbQt6FUd6V7CT56tLdcOFc7sCY/XcW4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SmLSXxjSf7gVZWAeTkbc+JRULMpn8SO546OUWWZ9YP8bJrK8ANPoaKt0Ohu8yo4ns zqZIX8LgKyFXEO073JwH01iOW4zTQxBM8ENOYrUJsGedDf+1iCsgnLkqvAYke/rS0f zy5XR6Jcd6Nm1bH6CChuCP0TZ4Npqay4pd5BA4qc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbgH0BfV (ORCPT ); Wed, 26 Aug 2020 21:35:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:52570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726784AbgH0BfV (ORCPT ); Wed, 26 Aug 2020 21:35:21 -0400 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF2462074A; Thu, 27 Aug 2020 01:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598492120; bh=7qVVxVRgHLIAbQt6FUd6V7CT56tLdcOFc7sCY/XcW4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a4pTmfB3sgIMJjFbdFWoRbsU8OwiaxyKW+QuNkBKy9GSWjT/k15qFfn7RLWNGDTqS BJFRsSmCpgtGwhOq/T+6lt8yzWWtRHNlVRLevw7dNAh1Rt4e+a2j4mum8/GxihxbsM uU2ZQwBWpuvRsTh7kYANI78/IqpYwQPC3C9ilcHY= Date: Wed, 26 Aug 2020 20:41:20 -0500 From: "Gustavo A. R. Silva" To: Jason Gunthorpe Cc: Alex Dewar , dennis.dalessandro@intel.com, dledford@redhat.com, gustavo@embeddedor.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, mike.marciniszyn@intel.com, roland@purestorage.com Subject: Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements Message-ID: <20200827014120.GD2671@embeddedor> References: <64d7e1c9-9c6a-93f3-ce0a-c24b1c236071@gmail.com> <20200825171242.448447-1-alex.dewar90@gmail.com> <20200825193327.GA5504@embeddedor> <20200826191859.GB2671@embeddedor> <20200827001149.GK24045@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200827001149.GK24045@ziepe.ca> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 09:11:49PM -0300, Jason Gunthorpe wrote: > On Wed, Aug 26, 2020 at 02:18:59PM -0500, Gustavo A. R. Silva wrote: > > Hi, > > > > On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote: > > > On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote: > > > > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > > > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which > > > > were later converted to fallthrough statements by commit df561f6688fe > > > > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity > > > > warning about unreachable code. > > > > > > > > > > It's worth mentioning that this warning is triggered only by compilers > > > that don't support __attribute__((__fallthrough__)), which has been > > > supported since GCC 7.1. > > > > > > > Remove the fallthrough statements. > > > > > > > > Addresses-Coverity: ("Unreachable code") > > > > Fixes: 36a8f01cd24b ("IB/qib: Add congestion control agent implementation") > > > > Signed-off-by: Alex Dewar > > > > > > Reviewed-by: Gustavo A. R. Silva > > > > > > > I can take this in my tree for 5.9-rc3. > > That would make conflicts for the 2nd patch, lets just send them all > through the rdma tree please. OK. > Is there a reason this is -rc material? It's just that this warning is currently in mainline. Thanks -- Gustavo