From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@nvidia.com>,
Leon Romanovsky <leonro@mellanox.com>,
<linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
Roland Dreier <rolandd@cisco.com>,
Sean Hefty <sean.hefty@intel.com>
Subject: Re: [PATCH rdma-next 00/14] Cleanup locking and events in ucma
Date: Thu, 27 Aug 2020 08:39:25 -0300 [thread overview]
Message-ID: <20200827113925.GA3996328@nvidia.com> (raw)
In-Reply-To: <20200818120526.702120-1-leon@kernel.org>
On Tue, Aug 18, 2020 at 03:05:12PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> >From Jason:
>
> Rework how the uevents for new connections are handled so all the locking
> ends up simpler and a work queue can be removed. This should also speed up
> destruction of ucma_context's as a flush_workqueue() was replaced with
> cancel_work_sync().
>
> The simpler locking comes from narrowing what file->mut covers and moving
> other data to other locks, particularly by injecting the handler_mutex
> from the RDMA CM core as a construct available to ULPs. The handler_mutex
> directly prevents handlers from running without creating any ABBA locking
> problems.
>
> Fix various error cases and data races caused by missing locking.
>
> Thanks
>
> Jason Gunthorpe (14):
> RDMA/ucma: Fix refcount 0 incr in ucma_get_ctx()
> RDMA/ucma: Remove unnecessary locking of file->ctx_list in close
> RDMA/ucma: Consolidate the two destroy flows
> RDMA/ucma: Fix error cases around ucma_alloc_ctx()
> RDMA/ucma: Remove mc_list and rely on xarray
> RDMA/cma: Add missing locking to rdma_accept()
> RDMA/ucma: Do not use file->mut to lock destroying
> RDMA/ucma: Fix the locking of ctx->file
> RDMA/ucma: Fix locking for ctx->events_reported
> RDMA/ucma: Add missing locking around rdma_leave_multicast()
> RDMA/ucma: Change backlog into an atomic
> RDMA/ucma: Narrow file->mut in ucma_event_handler()
> RDMA/ucma: Rework how new connections are passed through event
> delivery
> RDMA/ucma: Remove closing and the close_wq
Applied to for-next
Jason
prev parent reply other threads:[~2020-08-27 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 12:05 [PATCH rdma-next 00/14] Cleanup locking and events in ucma Leon Romanovsky
2020-08-27 11:39 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827113925.GA3996328@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox