From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953B9C433E1 for ; Thu, 27 Aug 2020 19:06:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 538DE207CD for ; Thu, 27 Aug 2020 19:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598555219; bh=vTHK2xAuoLPvz0B5okzq225ClGRruZ/zZapxLoQ371o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SFZO/tT4l6cG3yfM3EdRM/w2qUUqZdiJMLdXVBNg6B9bMnCr+q9T0GX2vIY06t0QW kOqv5BXrV9CHsKya+/kaaAEy3tLCAClOL13+igKeyp5x0x/OtrTt1eEQLogS5c16WO dEpdzrCEHjzm1lq2+2T8AfWCWMlnvORV/97IFE0s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727821AbgH0TG6 (ORCPT ); Thu, 27 Aug 2020 15:06:58 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:44241 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgH0TG5 (ORCPT ); Thu, 27 Aug 2020 15:06:57 -0400 Received: by mail-ej1-f67.google.com with SMTP id bo3so9096917ejb.11; Thu, 27 Aug 2020 12:06:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kX9eyuUyhq2QFDZPTT8K+fKfXv//9k/lun1Oefq69vQ=; b=kr2oH/9CxNs7iz8r8DpKFNCTMyQ28aGdp3TLDbLX5ElLn2zM/9q9ONlrMid5RvBVJi hjrxUbIVBwwNHG+Z0AcPDDAqcIZJ2Nk8ZOMjfQyFFHZeTq1yKxXeJtYFCn66Vss7wQEE CrJH2gdkN5y/i0sILTpZmY+D95+3Nn2ComTA8q+JmtKsJv+JQsGHzA9s347OUm+aLcUi b1VsdC5HhtupuibhJwnYGizsrJFxu+PcwyZ0PZXhAC0It5CxjJcWKd1XRzr3hfuMZRSf Ik5IpaDMmu9IV11nn3JLpMzthBQVZ4HIAS54WSDTR0UZbBvLNd9JkOH7lWt1DnX62KgP tbcg== X-Gm-Message-State: AOAM533p9tc3H6iMApibp4zFbz+Sg86BQHmy9naKiUYoBIzLaFKTgNJV 8lBnIFG9/lP1fk7p82yiWNxNu/vPWcjdUmdF X-Google-Smtp-Source: ABdhPJwErb1TPe6yej5LwLYtNxfx1kujrjSq4jsHJ5VaVSvbdjyWgjoSXSM2n9G+Y0DfBXVTqlVBtw== X-Received: by 2002:a17:906:37c1:: with SMTP id o1mr22299708ejc.279.1598555215565; Thu, 27 Aug 2020 12:06:55 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id w20sm2629985ejc.77.2020.08.27.12.06.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Aug 2020 12:06:54 -0700 (PDT) Date: Thu, 27 Aug 2020 21:06:52 +0200 From: Krzysztof Kozlowski To: Andy Shevchenko Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Maxime Coquelin , Alexandre Torgue , Fabrice Gasnier , Etienne Carriere , Alexandru Ardelean , linux-iio , linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH v2] iio: adc: stm32: Simplify with dev_err_probe() Message-ID: <20200827190652.GD6196@kozik-lap> References: <20200826161818.20969-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 27, 2020 at 11:27:12AM +0300, Andy Shevchenko wrote: > On Wed, Aug 26, 2020 at 7:19 PM Krzysztof Kozlowski wrote: > > > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > > > > > > priv->aclk = devm_clk_get(&pdev->dev, "adc"); > > if (IS_ERR(priv->aclk)) { > > ret = PTR_ERR(priv->aclk); > > - if (ret != -ENOENT) { > > - if (ret != -EPROBE_DEFER) > > - dev_err(&pdev->dev, "Can't get 'adc' clock\n"); > > - return ret; > > - } > > + if (ret != -ENOENT) > > + return dev_err_probe(&pdev->dev, ret, "Can't get 'adc' clock\n"); > > + > > priv->aclk = NULL; > > } > > > > priv->bclk = devm_clk_get(&pdev->dev, "bus"); > > if (IS_ERR(priv->bclk)) { > > ret = PTR_ERR(priv->bclk); > > - if (ret != -ENOENT) { > > - if (ret != -EPROBE_DEFER) > > - dev_err(&pdev->dev, "Can't get 'bus' clock\n"); > > - return ret; > > - } > > + if (ret != -ENOENT) > > + return dev_err_probe(&pdev->dev, ret, "Can't get 'bus' clock\n"); > > + > > priv->bclk = NULL; > > } > > Again, devm_clk_get_optional() and even, if it exists, > devm_clk_bulk_get_optional(). Sure. > > Please, revisit all patches on this topic. I'll check them. Best regards, Krzysztof