Re: [PATCH v2 04/18] iio: adc: exynos_adc: Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T19:47:14Z

On Thu, Aug 27, 2020 at 10:27 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Wrap dev_err_probe() lines at 100 character
> ---
> drivers/iio/adc/exynos_adc.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 7d23b6c33284..40585a96c848 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -844,13 +844,8 @@ static int exynos_adc_probe(struct platform_device *pdev)
> }
>
> info->vdd = devm_regulator_get(&pdev->dev, "vdd");
> - if (IS_ERR(info->vdd)) {
> - if (PTR_ERR(info->vdd) != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "failed getting regulator, err = %ld\n",
> - PTR_ERR(info->vdd));
> - return PTR_ERR(info->vdd);
> - }
> + if (IS_ERR(info->vdd))
> + return dev_err_probe(&pdev->dev, PTR_ERR(info->vdd), "failed getting regulator");
>
> ret = regulator_enable(info->vdd);
> if (ret)
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko