Re: [PATCH v2 15/18] iio: light: tsl2772: Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T20:00:58Z

On Thu, Aug 27, 2020 at 10:29 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Wrap dev_err_probe() lines at 100 character
> ---
> drivers/iio/light/tsl2772.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
> index 735399405417..d79205361dfa 100644
> --- a/drivers/iio/light/tsl2772.c
> +++ b/drivers/iio/light/tsl2772.c
> @@ -1776,14 +1776,8 @@ static int tsl2772_probe(struct i2c_client *clientp,
> ret = devm_regulator_bulk_get(&clientp->dev,
> ARRAY_SIZE(chip->supplies),
> chip->supplies);
> - if (ret < 0) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(&clientp->dev,
> - "Failed to get regulators: %d\n",
> - ret);
> -
> - return ret;
> - }
> + if (ret < 0)
> + return dev_err_probe(&clientp->dev, ret, "Failed to get regulators\n");
>
> ret = regulator_bulk_enable(ARRAY_SIZE(chip->supplies), chip->supplies);
> if (ret < 0) {
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko