Re: [PATCH v2 05/18] iio: adc: ltc2497: Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T19:48:32Z

On Thu, Aug 27, 2020 at 10:27 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Wrap dev_err_probe() lines at 100 character
> ---
> drivers/iio/adc/ltc2497-core.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c
> index 9b8fd9c32364..d337ed96bbb0 100644
> --- a/drivers/iio/adc/ltc2497-core.c
> +++ b/drivers/iio/adc/ltc2497-core.c
> @@ -180,13 +180,8 @@ int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev)
> return ret;
>
> ddata->ref = devm_regulator_get(dev, "vref");
> - if (IS_ERR(ddata->ref)) {
> - if (PTR_ERR(ddata->ref) != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get vref regulator: %pe\n",
> - ddata->ref);
> -
> - return PTR_ERR(ddata->ref);
> - }
> + if (IS_ERR(ddata->ref))
> + return dev_err_probe(dev, PTR_ERR(ddata->ref), "Failed to get vref regulator\n");
>
> ret = regulator_enable(ddata->ref);
> if (ret < 0) {
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko