Re: [PATCH v2 13/18] iio: imu: inv_mpu6050: Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T19:59:52Z

On Thu, Aug 27, 2020 at 10:28 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 20 ++++++--------------
> 1 file changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 3fee3947f772..18a1898e3e34 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -1475,22 +1475,14 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name,
> }
>
> st->vdd_supply = devm_regulator_get(dev, "vdd");
> - if (IS_ERR(st->vdd_supply)) {
> - if (PTR_ERR(st->vdd_supply) != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get vdd regulator %d\n",
> - (int)PTR_ERR(st->vdd_supply));
> -
> - return PTR_ERR(st->vdd_supply);
> - }
> + if (IS_ERR(st->vdd_supply))
> + return dev_err_probe(dev, PTR_ERR(st->vdd_supply),
> + "Failed to get vdd regulator\n");
>
> st->vddio_supply = devm_regulator_get(dev, "vddio");
> - if (IS_ERR(st->vddio_supply)) {
> - if (PTR_ERR(st->vddio_supply) != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get vddio regulator %d\n",
> - (int)PTR_ERR(st->vddio_supply));
> -
> - return PTR_ERR(st->vddio_supply);
> - }
> + if (IS_ERR(st->vddio_supply))
> + return dev_err_probe(dev, PTR_ERR(st->vddio_supply),
> + "Failed to get vddio regulator\n");
>
> result = regulator_enable(st->vdd_supply);
> if (result) {
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko