Re: [PATCH v2 10/18] iio: amplifiers: hmc425a: Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T19:55:26Z

On Thu, Aug 27, 2020 at 10:28 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Wrap dev_err_probe() lines at 100 character
> ---
> drivers/iio/amplifiers/hmc425a.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc425a.c
> index 582708924e4f..bde11df4bb9e 100644
> --- a/drivers/iio/amplifiers/hmc425a.c
> +++ b/drivers/iio/amplifiers/hmc425a.c
> @@ -201,12 +201,8 @@ static int hmc425a_probe(struct platform_device *pdev)
> st->gain = st->chip_info->default_gain;
>
> st->gpios = devm_gpiod_get_array(&pdev->dev, "ctrl", GPIOD_OUT_LOW);
> - if (IS_ERR(st->gpios)) {
> - ret = PTR_ERR(st->gpios);
> - if (ret != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "failed to get gpios\n");
> - return ret;
> - }
> + if (IS_ERR(st->gpios))
> + return dev_err_probe(&pdev->dev, PTR_ERR(st->gpios), "failed to get gpios\n");
>
> if (st->gpios->ndescs != st->chip_info->num_gpios) {
> dev_err(&pdev->dev, "%d GPIOs needed to operate\n",
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko