Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe()

Andy Shevchenko
2020-08-27T19:55:04Z

On Thu, Aug 27, 2020 at 10:28 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and also it prints the error value.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Wrap dev_err_probe() lines at 100 character
> ---
> drivers/iio/afe/iio-rescale.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
> index 69c0f277ada0..8cd9645c50e8 100644
> --- a/drivers/iio/afe/iio-rescale.c
> +++ b/drivers/iio/afe/iio-rescale.c
> @@ -276,11 +276,8 @@ static int rescale_probe(struct platform_device *pdev)
> int ret;
>
> source = devm_iio_channel_get(dev, NULL);
> - if (IS_ERR(source)) {
> - if (PTR_ERR(source) != -EPROBE_DEFER)
> - dev_err(dev, "failed to get source channel\n");
> - return PTR_ERR(source);
> - }
> + if (IS_ERR(source))
> + return dev_err_probe(dev, PTR_ERR(source), "failed to get source channel\n");
>
> sizeof_ext_info = iio_get_channel_ext_info_count(source);
> if (sizeof_ext_info) {
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko