From: Krzysztof Kozlowski <krzk@kernel.org>
To: santosh.shilimkar@oracle.com
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] memory: emif: Remove bogus debugfs error handling
Date: Thu, 27 Aug 2020 21:35:40 +0200 [thread overview]
Message-ID: <20200827193540.GA8837@kozik-lap> (raw)
In-Reply-To: <10387fe0-579a-de71-44ad-ac585ff604d6@oracle.com>
On Wed, Aug 26, 2020 at 09:52:37AM -0700, santosh.shilimkar@oracle.com wrote:
> On 8/26/20 4:37 AM, Dan Carpenter wrote:
> > Callers are generally not supposed to check the return values from
> > debugfs functions. Debugfs functions never return NULL so this error
> > handling will never trigger. (Historically debugfs functions used to
> > return a mix of NULL and error pointers but it was eventually deemed too
> > complicated for something which wasn't intended to be used in normal
> > situations).
> >
> > Delete all the error handling.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> Looks good to me !!
>
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Thanks, applied.
Santosh,
Your email does not match one in ack. I understand this is just a
mistake so I put the ack. However the tool (b4-am) ignores such cases
so ack could be lost in the future.
Best regards,
Krzysztof
prev parent reply other threads:[~2020-08-27 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 11:37 [PATCH] memory: emif: Remove bogus debugfs error handling Dan Carpenter
2020-08-26 16:52 ` santosh.shilimkar
2020-08-27 19:35 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827193540.GA8837@kozik-lap \
--to=krzk@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox