From: Greg KH <gregkh@linuxfoundation.org>
To: Tong Zhang <ztong0001@gmail.com>
Cc: jirislaby@kernel.org, robh@kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v4] tty: serial: earlycon dependency
Date: Fri, 28 Aug 2020 10:20:15 +0200 [thread overview]
Message-ID: <20200828082015.GA1052883@kroah.com> (raw)
In-Reply-To: <20200818185458.84418-1-ztong0001@gmail.com>
On Tue, Aug 18, 2020 at 02:54:59PM -0400, Tong Zhang wrote:
> parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> should automatically select SERIAL_CORE, otherwise will result in symbol
> not found error during linking if SERIAL_CORE is not configured as builtin
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
>
> Fixes: 9aac5887595b ("tty/serial: add generic serial earlycon")
This should be up above your signed-off-by line.
Can you fix that up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-28 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 16:50 [PATCH] tty: serial: fix earlycon dependency Tong Zhang
2020-08-17 17:00 ` Greg KH
2020-08-17 17:25 ` Tong Zhang
2020-08-17 18:54 ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
2020-08-18 5:42 ` Jiri Slaby
2020-08-18 11:19 ` Greg KH
2020-08-18 16:25 ` [PATCH v3] " Tong Zhang
2020-08-18 18:54 ` [PATCH v4] " Tong Zhang
2020-08-28 8:20 ` Greg KH [this message]
2020-08-28 12:39 ` [PATCH v5] " Tong Zhang
2020-08-28 12:41 ` [PATCH v4] " Tong Zhang
2020-08-18 16:27 ` [PATCH v2] Fixes: " Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828082015.GA1052883@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh@kernel.org \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox