From: Greg KH <gregkh@linuxfoundation.org>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: jbaron@akamai.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"
Date: Fri, 28 Aug 2020 12:31:06 +0200 [thread overview]
Message-ID: <20200828103106.GE1470435@kroah.com> (raw)
In-Reply-To: <20200825173339.2082585-4-jim.cromie@gmail.com>
On Tue, Aug 25, 2020 at 11:33:39AM -0600, Jim Cromie wrote:
> 14775b049642 dyndbg: accept query terms like file=bar and module=foo
>
What does that above line mean???
> That commit broke on a tokenization modality where a word could start
> with a quote, but couldnt continue with one. So the above would
> tokenize as 'format="foo' and 'bar"', and fail hard.
>
> This commit fixes the tokenizer by terminating an unquoted token on
> the '=', avoiding that problem. And since ddebug-parse-query will
> never see a combined 'keyword=value', revert those parts of the
> previous commit.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Again, a Fixes: tag, and fix up your text above please.
Can you do this and send a v3 of this series and any other pending
dyndbg fixes for 5.9-final?
thanks,
greg k-h
prev parent reply other threads:[~2020-08-28 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 17:33 [PATCH-v2 0/3] dynamic-debug fixups for 5.9 Jim Cromie
2020-08-25 17:33 ` [PATCH v2 1/3] dyndbg: give %3u width in pr-format, cosmetic only Jim Cromie
2020-08-25 17:33 ` [PATCH v2 2/3] dyndbg: refine export, rename to dynamic_debug_exec_queries() Jim Cromie
2020-08-28 10:30 ` Greg KH
2020-08-25 17:33 ` [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar" Jim Cromie
2020-08-28 0:16 ` [dyndbg] 738b8a92be: kernel_BUG_at_lib/dynamic_debug.c kernel test robot
2020-08-28 10:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828103106.GE1470435@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox