Re: [PATCH v3 1/1] netfilter: nat: add a range check for l3/l4 protonum

Florian Westphal
2020-08-28T16:46:20Z

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Will,
>
> Given this is for -stable maintainers only, I'd suggest:
>
> 1) Specify what -stable kernel versions this patch applies to.
> Explain that this problem is gone since what kernel version.
>
> 2) Maybe clarify that this is only for stable in the patch subject,
> e.g. [PATCH -stable v3] netfilter: nat: add a range check for l3/l4

Hmm, we silently accept a tuple that we can't really deal with, no?

> > + if (l3num != NFPROTO_IPV4 && l3num != NFPROTO_IPV6)
> > + return -EOPNOTSUPP;

I vote to apply this to nf.git