Re: [PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

kernel test robot
2020-08-28T10:39:42Z

[-- Attachment #1: Type: text/plain, Size: 18363 bytes --]

Hi Chunguang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next linus/master v5.9-rc2 next-20200827]
[cannot apply to asm-generic/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from include/linux/kernel.h:11,
from fs/afs/file.c:8:
fs/afs/file.c: In function 'afs_readpage':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/file.c:398:3: note: in expansion of macro 'ASSERT'
398 | ASSERT(key != NULL);
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/file.c:398:3: note: in expansion of macro 'ASSERT'
398 | ASSERT(key != NULL);
| ^~~~~~
fs/afs/file.c: In function 'afs_readpages':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/file.c:553:2: note: in expansion of macro 'ASSERT'
553 | ASSERT(key != NULL);
| ^~~~~~
--
In file included from fs/afs/internal.h:8,
from fs/afs/flock.c:8:
fs/afs/flock.c: In function 'afs_lock_work':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/flock.c:326:3: note: in expansion of macro 'ASSERT'
326 | ASSERT(!list_empty(&vnode->granted_locks));
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/flock.c:326:3: note: in expansion of macro 'ASSERT'
326 | ASSERT(!list_empty(&vnode->granted_locks));
| ^~~~~~
fs/afs/flock.c: In function 'afs_do_setlk':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/flock.c:591:3: note: in expansion of macro 'ASSERT'
591 | ASSERT(list_empty(&vnode->granted_locks));
| ^~~~~~
--
In file included from include/linux/init.h:5,
from fs/afs/fsclient.c:8:
fs/afs/fsclient.c: In function 'afs_fs_setattr_size64':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/fsclient.c:1224:2: note: in expansion of macro 'ASSERT'
1224 | ASSERT(attr->ia_valid & ATTR_SIZE);
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/fsclient.c:1224:2: note: in expansion of macro 'ASSERT'
1224 | ASSERT(attr->ia_valid & ATTR_SIZE);
| ^~~~~~
fs/afs/fsclient.c: In function 'afs_fs_setattr_size':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/fsclient.c:1266:2: note: in expansion of macro 'ASSERT'
1266 | ASSERT(attr->ia_valid & ATTR_SIZE);
| ^~~~~~
--
In file included from include/linux/kernel.h:11,
from fs/afs/fs_operation.c:8:
fs/afs/fs_operation.c: In function 'afs_begin_vnode_operation':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/fs_operation.c:138:2: note: in expansion of macro 'ASSERT'
138 | ASSERT(vnode);
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/fs_operation.c:138:2: note: in expansion of macro 'ASSERT'
138 | ASSERT(vnode);
| ^~~~~~
fs/afs/fs_operation.c:136:20: warning: unused variable 'vnode' [-Wunused-variable]
136 | struct afs_vnode *vnode = op->file[0].vnode;
| ^~~~~
--
In file included from include/linux/kernel.h:11,
from fs/afs/mntpt.c:8:
fs/afs/mntpt.c: In function 'afs_mntpt_kill_timer':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/mntpt.c:224:2: note: in expansion of macro 'ASSERT'
224 | ASSERT(list_empty(&afs_vfsmounts));
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/mntpt.c:224:2: note: in expansion of macro 'ASSERT'
224 | ASSERT(list_empty(&afs_vfsmounts));
| ^~~~~~
--
In file included from include/linux/kernel.h:11,
from fs/afs/rotate.c:8:
fs/afs/rotate.c: In function 'afs_select_fileserver':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/rotate.c:398:2: note: in expansion of macro 'ASSERT'
398 | ASSERT(op->ac.alist);
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/rotate.c:398:2: note: in expansion of macro 'ASSERT'
398 | ASSERT(op->ac.alist);
| ^~~~~~
--
In file included from include/asm-generic/bug.h:5,
from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from fs/afs/rxrpc.c:8:
fs/afs/rxrpc.c: In function 'afs_put_call':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/rxrpc.c:174:3: note: in expansion of macro 'ASSERT'
174 | ASSERT(!work_pending(&call->async_work));
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/rxrpc.c:174:3: note: in expansion of macro 'ASSERT'
174 | ASSERT(!work_pending(&call->async_work));
| ^~~~~~
fs/afs/rxrpc.c: In function 'afs_make_call':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/rxrpc.c:371:2: note: in expansion of macro 'ASSERT'
371 | ASSERT(call->type != NULL);
| ^~~~~~
--
In file included from include/asm-generic/bug.h:5,
from arch/sh/include/asm/bug.h:112,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from fs/afs/server.c:8:
fs/afs/server.c: In function 'afs_check_server_record':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/server.c:671:2: note: in expansion of macro 'ASSERT'
671 | ASSERT(server);
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/server.c:671:2: note: in expansion of macro 'ASSERT'
671 | ASSERT(server);
| ^~~~~~
--
In file included from include/linux/kernel.h:11,
from fs/afs/callback.c:16:
fs/afs/callback.c: In function 'afs_break_callbacks':
>> fs/afs/internal.h:1583:31: error: 'x' undeclared (first use in this function)
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/callback.c:179:2: note: in expansion of macro 'ASSERT'
179 | ASSERT(server != NULL);
| ^~~~~~
fs/afs/internal.h:1583:31: note: each undeclared identifier is reported only once for each function it appears in
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/afs/internal.h:1583:19: note: in expansion of macro 'ASSERT_FAIL'
1583 | #define ASSERT(X) ASSERT_FAIL(x)
| ^~~~~~~~~~~
fs/afs/callback.c:179:2: note: in expansion of macro 'ASSERT'
179 | ASSERT(server != NULL);
| ^~~~~~
..

# https://github.com/0day-ci/linux/commit/16d044e9c58d5bce6b15c15a2d4a06c32006837d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
git checkout 16d044e9c58d5bce6b15c15a2d4a06c32006837d
vim +/x +1583 fs/afs/internal.h

1582
> 1583 #define ASSERT(X) ASSERT_FAIL(x)
1584

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52700 bytes --]