public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Kyung Min Park <kyung.min.park@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
	tony.luck@intel.com, dave.hansen@intel.com,
	ricardo.neri@intel.com, hpa@zytor.com,
	gregkh@linuxfoundation.org, ak@linux.intel.com,
	ravi.v.shankar@intel.com,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: Re: [PATCH v2] Documentation/x86: Add documentation for /proc/cpuinfo feature flags
Date: Fri, 28 Aug 2020 20:42:09 +0200	[thread overview]
Message-ID: <20200828184209.GC19342@zn.tnic> (raw)
In-Reply-To: <20200824180412.9440-1-kyung.min.park@intel.com>

On Mon, Aug 24, 2020 at 11:04:12AM -0700, Kyung Min Park wrote:
> +If the expected flag does not appear in /proc/cpuinfo, things are murkier.
> +Users need to find out the reason why the flag is missing and find the way
> +how to enable it, which is not always easy. There are several factors that
> +can explain missing flags: the expected feature failed to enable, the feature
> +is missing in hardware, platform firmware did not enable it, the feature is
> +disabled at build or run time, an old kernel is in use, or the kernel does
> +not support the feature and thus has not enabled it. In general, /proc/cpuinfo
> +shows features which the kernel supports.
> +
> +For a full list of CPUID flags which the CPU supports, the users may use
> +tools like http://www.etallen.com/cpuid.html (which is not updated with
> +kernel releases) or other custom tools that read CPUID.

I guess this should talk only about our own kcpuid tool since we wanna
do that now, right?

...

> +c: The kernel disabled support for it at compile-time.
> +------------------------------------------------------
> +For example, if 5-level-paging is not enabled when building (i.e.,
> +CONFIG_X86_5LEVEL is not selected) the flag "la57" will not show up [#f1]_.
> +Even though the feature will still be detected via CPUID, the kernel disables
> +it via cleared by setup_clear_cpu_cap(X86_FEATURE_LA57).

"... disables it by clearing... "

> +d: The feature is disabled at boot-time.
> +----------------------------------------
> +A feature can be disabled either using a command-line parameter or because
> +it failed to be enabled. The command-line parameter clearcpuid= can be used
> +to disable features using the feature number as defined in
> +/arch/x86/include/asm/cpufeatures.h. For instance, User Mode Instruction
> +Protection can be disabled using clearcpuid=514. The number 514 is calculated
> +from #define X86_FEATURE_UMIP (16*32 + 2).
> +
> +In addition, there exists a variety of custom command-line parameters that
> +disable specific features. The list of parameters includes, but is not limited
> +to, no5lvl, nosmap, and nosmep.

You already give the separate example for "no5lvl" below so use something else
above, say, "nofsgsbase", for example.

> 5-level paging can also be disabled using
> +"no5lvl". SMAP and SMEP are disabled with the aforementioned parameters,
> +respectively.
> +
> +e: The feature was known to be non-functional.
> +----------------------------------------------
> +The feature was known to be non-functional because a dependency was
> +missing at runtime. For example, AVX flags will not show up if XSAVE feature
> +is disabled since they depend on XSAVE feature.

Another example would be: broken CPUs and them missing microcode patches
and due to that the kernel deciding not to enable a feature.

But yap, all in all looks like a good idea. I'll take the next version
after you've fixed those nitpicks.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2020-08-28 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 18:04 [PATCH v2] Documentation/x86: Add documentation for /proc/cpuinfo feature flags Kyung Min Park
2020-08-28 18:42 ` Borislav Petkov [this message]
2020-08-28 22:30   ` Kyung Min Park
2020-08-30 11:50     ` Borislav Petkov
2020-08-30 21:21       ` Kyung Min Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828184209.GC19342@zn.tnic \
    --to=bp@alien8.de \
    --cc=ak@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=kyung.min.park@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=ricardo.neri@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox