From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Alexandre Courbot <acourbot@chromium.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel@collabora.com>,
linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] remoteproc: scp: add COMPILE_TEST dependency
Date: Sun, 30 Aug 2020 12:56:09 +0200 [thread overview]
Message-ID: <20200830125601.468a24d8@coco.lan> (raw)
In-Reply-To: <20200821115832.2893484-1-acourbot@chromium.org>
Em Fri, 21 Aug 2020 20:58:32 +0900
Alexandre Courbot <acourbot@chromium.org> escreveu:
> This will improve this driver's build coverage.
There is a pending pull request for media which seems to depend
on this patch. Without it, COMPILE_TEST breaks at linux-media
git tree, if I pick it. See:
https://lore.kernel.org/linux-media/20200830104650.0dd4d751@coco.lan/T/#t
The best here would be to get an ack from the remoteproc
maintainers to get this patch merged via the media tree.
Alternatively, this patch could be applied on a stable topic branch
at remoteproc tree, which would be merged at the media tree, or
cherry-picked on media after being committed at remoteproc tree.
Regards,
Mauro
>
> Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> drivers/remoteproc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index c6659dfea7c7..d1fcada71017 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
>
> config MTK_SCP
> tristate "Mediatek SCP support"
> - depends on ARCH_MEDIATEK
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> select RPMSG_MTK_SCP
> help
> Say y here to support Mediatek's System Companion Processor (SCP) via
Thanks,
Mauro
prev parent reply other threads:[~2020-08-30 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 11:58 [PATCH] remoteproc: scp: add COMPILE_TEST dependency Alexandre Courbot
2020-08-30 10:56 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830125601.468a24d8@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=acourbot@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox