Re: [PATCH] remoteproc: scp: add COMPILE_TEST dependency

Mauro Carvalho Chehab
2020-08-30T10:56:49Z

Em Fri, 21 Aug 2020 20:58:32 +0900
Alexandre Courbot <acourbot@chromium.org> escreveu:

> This will improve this driver's build coverage.

There is a pending pull request for media which seems to depend
on this patch. Without it, COMPILE_TEST breaks at linux-media
git tree, if I pick it. See:

https://lore.kernel.org/linux-media/20200830104650.0dd4d751@coco.lan/T/#t

The best here would be to get an ack from the remoteproc
maintainers to get this patch merged via the media tree.

Alternatively, this patch could be applied on a stable topic branch
at remoteproc tree, which would be merged at the media tree, or
cherry-picked on media after being committed at remoteproc tree.

Regards,
Mauro

>
> Reported-by: Ezequiel Garcia <ezequiel@collabora.com>
> Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> drivers/remoteproc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index c6659dfea7c7..d1fcada71017 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -43,7 +43,7 @@ config INGENIC_VPU_RPROC
>
> config MTK_SCP
> tristate "Mediatek SCP support"
> - depends on ARCH_MEDIATEK
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> select RPMSG_MTK_SCP
> help
> Say y here to support Mediatek's System Companion Processor (SCP) via

Thanks,
Mauro