Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3

Marek Szyprowski
2020-08-31T08:31:40Z

Hi Krzysztof,

On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warning:
>
> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

I think that this was intentional to properly enable support for
mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the
default values if no pinctrl properties are provided. Sylwester, could
you comment?

> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index a5c1ce1e396c..6d3576e21ffa 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -136,8 +136,6 @@
>
> &camera {
> status = "okay";
> - pinctrl-names = "default";
> - pinctrl-0 = <>;
> };
>
> &clock {

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland