From: Sumera Priyadarsini <sylphrenadin@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] bus: arm: Add of_node_put() before break statement
Date: Mon, 31 Aug 2020 08:39:53 +0530 [thread overview]
Message-ID: <20200831030953.GA8285@Kaladin> (raw)
Every iteration of for_each_available_child_of_node() decrements the
reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a
return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.
Fix a potential memory leak in arm-cci.c by inserting
of_node_put() before a break statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
i = nb_ace + nb_ace_lite;
- if (i >= nb_cci_ports)
+ if (i >= nb_cci_ports) {
+ of_node_put(cp);
break;
+ }
if (of_property_read_string(cp, "interface-type",
&match_str)) {
--
2.17.1
reply other threads:[~2020-08-31 3:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831030953.GA8285@Kaladin \
--to=sylphrenadin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox