From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472D0C433E2 for ; Mon, 31 Aug 2020 15:33:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17C8E207EA for ; Mon, 31 Aug 2020 15:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598888004; bh=eySNeSs6dVycPr5WJLZaEg/u4b3EQfaJkXxHGmlbQGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=D2js2Q3e18nPFkKfHB0I/S4pQry4ozPS3meKPtGQmPP1MDKN4vWXxWkBZHB0A0o8+ 6iuifp2aEwq02/nU+GnM1WePlYhauGA0d5Up8aga4NAkmqFVWdWqMblV9Hcre6HTUa viLmGiHW2udmGtX6XimqACva0eyPr461Ek7DGO90= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729190AbgHaPdW (ORCPT ); Mon, 31 Aug 2020 11:33:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:43270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728064AbgHaPb5 (ORCPT ); Mon, 31 Aug 2020 11:31:57 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 80C1E214D8; Mon, 31 Aug 2020 15:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598887917; bh=eySNeSs6dVycPr5WJLZaEg/u4b3EQfaJkXxHGmlbQGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L7j6HfL+aopmKHvDTubocV9DZ36iZcoxuRxikgTMlTfgF+d4OL2EvRnMnzkEOdthj /5IgF+sPLkYD4KbvWmf5UtEnFNPfqHLoxiav91UsLVjIrZ1Bv+DV3s/l8EiAN/sCHJ V1vJV3vBagyk6XXAejxpkGLMl9wHrzB2GKBlxcdk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeff Layton , Ilya Dryomov , Sasha Levin , ceph-devel@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 4/6] ceph: don't allow setlease on cephfs Date: Mon, 31 Aug 2020 11:31:47 -0400 Message-Id: <20200831153150.1024799-4-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200831153150.1024799-1-sashal@kernel.org> References: <20200831153150.1024799-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Layton [ Upstream commit 496ceaf12432b3d136dcdec48424312e71359ea7 ] Leases don't currently work correctly on kcephfs, as they are not broken when caps are revoked. They could eventually be implemented similarly to how we did them in libcephfs, but for now don't allow them. [ idryomov: no need for simple_nosetlease() in ceph_dir_fops and ceph_snapdir_fops ] Signed-off-by: Jeff Layton Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index e7ddb23d9bb73..e818344a052cb 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1773,6 +1773,7 @@ const struct file_operations ceph_file_fops = { .mmap = ceph_mmap, .fsync = ceph_fsync, .lock = ceph_lock, + .setlease = simple_nosetlease, .flock = ceph_flock, .splice_write = iter_file_splice_write, .unlocked_ioctl = ceph_ioctl, -- 2.25.1