From: paulmck@kernel.org
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH tip/core/rcu 12/14] rcutorture: Hoist OOM registry up one level
Date: Mon, 31 Aug 2020 11:04:04 -0700 [thread overview]
Message-ID: <20200831180406.494-12-paulmck@kernel.org> (raw)
In-Reply-To: <20200831180348.GA416@paulmck-ThinkPad-P72>
From: "Paul E. McKenney" <paulmck@kernel.org>
Currently, registering and unregistering the OOM notifier is done
right before and after the test, respectively. This will not work
well for multi-threaded tests, so this commit hoists this registering
and unregistering up into the rcu_torture_fwd_prog_init() and
rcu_torture_fwd_prog_cleanup() functions.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
kernel/rcu/rcutorture.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 2b3f04e..983f82f 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -2110,13 +2110,11 @@ static int rcu_torture_fwd_prog(void *args)
do {
schedule_timeout_interruptible(fwd_progress_holdoff * HZ);
WRITE_ONCE(rcu_fwd_emergency_stop, false);
- register_oom_notifier(&rcutorture_oom_nb);
if (!IS_ENABLED(CONFIG_TINY_RCU) ||
rcu_inkernel_boot_has_ended())
rcu_torture_fwd_prog_nr(rfp, &tested, &tested_tries);
if (rcu_inkernel_boot_has_ended())
rcu_torture_fwd_prog_cr(rfp);
- unregister_oom_notifier(&rcutorture_oom_nb);
/* Avoid slow periods, better to test when busy. */
stutter_wait("rcu_torture_fwd_prog");
@@ -2159,6 +2157,7 @@ static int __init rcu_torture_fwd_prog_init(void)
mutex_lock(&rcu_fwd_mutex);
rcu_fwds = rfp;
mutex_unlock(&rcu_fwd_mutex);
+ register_oom_notifier(&rcutorture_oom_nb);
return torture_create_kthread(rcu_torture_fwd_prog, rfp, fwd_prog_task);
}
@@ -2171,6 +2170,7 @@ static void rcu_torture_fwd_prog_cleanup(void)
mutex_lock(&rcu_fwd_mutex);
rcu_fwds = NULL;
mutex_unlock(&rcu_fwd_mutex);
+ unregister_oom_notifier(&rcutorture_oom_nb);
kfree(rfp);
}
--
2.9.5
next prev parent reply other threads:[~2020-08-31 18:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 18:03 [PATCH tip/core/rcu 0/14] Torture-test updates for v5.10 Paul E. McKenney
2020-08-31 18:03 ` [PATCH tip/core/rcu 01/14] rcutorture: Remove KCSAN stubs paulmck
2020-08-31 18:03 ` [PATCH tip/core/rcu 02/14] rcutorture: Output number of elapsed grace periods paulmck
2020-08-31 18:03 ` [PATCH tip/core/rcu 03/14] torture: document --allcpus argument added to the kvm.sh script paulmck
2020-08-31 18:03 ` [PATCH tip/core/rcu 04/14] locktorture: Make function torture_percpu_rwsem_init() static paulmck
2020-08-31 18:03 ` [PATCH tip/core/rcu 05/14] rcutorture: Replace HTTP links with HTTPS ones paulmck
2020-08-31 18:03 ` [PATCH tip/core/rcu 06/14] torture: Update initrd documentation paulmck
2020-08-31 18:03 ` [PATCH tip/core/rcu 07/14] rcutorture: Add CONFIG_PROVE_RCU_LIST to TREE05 paulmck
2020-08-31 18:04 ` [PATCH tip/core/rcu 08/14] torture: Add kvm.sh --help and update help message paulmck
2020-08-31 18:04 ` [PATCH tip/core/rcu 09/14] rcutorture: Properly set rcu_fwds for OOM handling paulmck
2020-08-31 18:04 ` [PATCH tip/core/rcu 10/14] rcutorture: Properly synchronize with OOM notifier paulmck
2020-08-31 18:04 ` [PATCH tip/core/rcu 11/14] refperf: Avoid null pointer dereference when buf fails to allocate paulmck
2020-08-31 18:04 ` paulmck [this message]
2020-08-31 18:04 ` [PATCH tip/core/rcu 13/14] rcutorture: Allow pointer leaks to test diagnostic code paulmck
2020-08-31 18:04 ` [PATCH tip/core/rcu 14/14] torture: Add gdb support paulmck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831180406.494-12-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox