public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: paulmck@kernel.org
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
	mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
	josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
	rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
	fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
	"Paul E. McKenney" <paulmck@kernel.org>
Subject: [PATCH tip/core/rcu 05/19] tick-sched: Clarify "NOHZ: local_softirq_pending" warning
Date: Mon, 31 Aug 2020 11:07:35 -0700	[thread overview]
Message-ID: <20200831180749.843-5-paulmck@kernel.org> (raw)
In-Reply-To: <20200831180731.GA582@paulmck-ThinkPad-P72>

From: "Paul E. McKenney" <paulmck@kernel.org>

Currently, can_stop_idle_tick() prints "NOHZ: local_softirq_pending HH"
(where "HH" is the hexadecimal softirq vector number) when one or more
non-RCU softirq handlers are still enabled when checking to stop the
scheduler-tick interrupt.  This message is not as enlightening as one
might hope, so this commit changes it to "NOHZ tick-stop error: Non-RCU
local softirq work is pending, handler #HH".

Reported-by: Andy Lutomirski <luto@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
 kernel/time/tick-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index f0199a4..81632cd 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -927,7 +927,7 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 
 		if (ratelimit < 10 &&
 		    (local_softirq_pending() & SOFTIRQ_STOP_IDLE_MASK)) {
-			pr_warn("NOHZ: local_softirq_pending %02x\n",
+			pr_warn("NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #%02x!!!\n",
 				(unsigned int) local_softirq_pending());
 			ratelimit++;
 		}
-- 
2.9.5


  parent reply	other threads:[~2020-08-31 18:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 18:07 [PATCH tip/core/rcu 0/19] New smp_call_function() torture test for v5.10 Paul E. McKenney
2020-08-31 18:07 ` [PATCH tip/core/rcu 01/19] scftorture: Add smp_call_function() torture test paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 02/19] torture: Declare parse-console.sh independence from rcutorture paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 03/19] torture: Add scftorture to the rcutorture scripting paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 04/19] scftorture: Implement weighted primitive selection paulmck
2020-08-31 18:07 ` paulmck [this message]
2020-08-31 18:07 ` [PATCH tip/core/rcu 06/19] scftorture: Summarize per-thread statistics paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 07/19] scftorture: Add smp_call_function_single() memory-ordering checks paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 08/19] scftorture: Add smp_call_function_many() " paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 09/19] scftorture: Add smp_call_function() " paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 10/19] scftorture: Consolidate scftorture_invoke_one() check and kfree() paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 11/19] scftorture: Consolidate scftorture_invoke_one() scf_check initialization paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 12/19] scftorture: Flag errors in torture-compatible manner paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 13/19] scftorture: Prevent compiler from reducing race probabilities paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 14/19] scftorture: Make symbol 'scf_torture_rand' static paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 15/19] scftorture: Check unexpected "switch" statement value paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 16/19] scftorture: Block scftorture_invoker() kthreads for offline CPUs paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 17/19] scftorture: Adapt memory-ordering test to UP operation paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 18/19] scftorture: Add cond_resched() to test loop paulmck
2020-08-31 18:07 ` [PATCH tip/core/rcu 19/19] rcuperf: Change rcuperf to rcuscale paulmck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831180749.843-5-paulmck@kernel.org \
    --to=paulmck@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=edumazet@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox