From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE9FC433E2 for ; Mon, 31 Aug 2020 22:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE4F32083E for ; Mon, 31 Aug 2020 22:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598912872; bh=COccaoCentRZDwlGDX0AKqRH7N87uuV5WYIUAGnaOCw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=N0a+2xxV2QRUNKes8F/cucOf2eyTucqHeHI6CTmNBiXO006L63YHtMV+Ois/GPj+y oxKyzo0SWEbZlJ1N3qeyUT3tM6yQ2cKIyfFFhxyd77vsGv0jgKQZj98wmsK7sF+Ulw +y6N+ouDjAZs0UFgjZHEdvO709+BChxM975lUeN0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbgHaW1v (ORCPT ); Mon, 31 Aug 2020 18:27:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:58402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbgHaW1t (ORCPT ); Mon, 31 Aug 2020 18:27:49 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97B90207EA; Mon, 31 Aug 2020 22:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598912869; bh=COccaoCentRZDwlGDX0AKqRH7N87uuV5WYIUAGnaOCw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lfp3/WS/XEoW9gO/i1hASubpnoUPH6RlKFRtc3cdecFhlfUHoSrld92piyjA2puZu HX2ivOWL6gsZnt6zCsPtFGWbUB5bBeqiX+ZOuGNdG9BDN1bhCRK0UmoM/BIdlaopjj wQdKfhanj4I96PxvJQw6NJqMw7/lxGfzdxbaF6x4= Date: Tue, 1 Sep 2020 07:27:45 +0900 From: Masami Hiramatsu To: Randy Dunlap Cc: Steven Rostedt , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 5/6] Documentation: tracing: Add %return suffix description Message-Id: <20200901072745.9ca00fc7efeabe9f0cf479e6@kernel.org> In-Reply-To: <210c7494-da9e-5314-c648-917493081c32@infradead.org> References: <159887792384.1330989.5993224243767476896.stgit@devnote2> <159887797048.1330989.6092698289026009625.stgit@devnote2> <210c7494-da9e-5314-c648-917493081c32@infradead.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2020 11:50:20 -0700 Randy Dunlap wrote: > On 8/31/20 5:46 AM, Masami Hiramatsu wrote: > > Add a description of the %return suffix option for kprobe tracer. > > > > Signed-off-by: Masami Hiramatsu > > --- > > Documentation/trace/kprobetrace.rst | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/trace/kprobetrace.rst b/Documentation/trace/kprobetrace.rst > > index c1709165c553..d29d1f9e6721 100644 > > --- a/Documentation/trace/kprobetrace.rst > > +++ b/Documentation/trace/kprobetrace.rst > > Check spacing: > > > @@ -37,6 +38,7 @@ Synopsis of kprobe_events > > based on SYM+offs or MEMADDR. > > MOD : Module name which has given SYM. > > SYM[+offs] : Symbol+offset where the probe is inserted. > > + SYM%return : Return address of the symbol > > MEMADDR : Address where the probe is inserted. > > MAXACTIVE : Maximum number of instances of the specified function that > > can be probed simultaneously, or 0 for the default value > > If I remove the '+', the ':' lines up but the SYM does not line up. > Am I missing something? > > @@ -37,6 +38,7 @@ Synopsis of kprobe_events > based on SYM+offs or MEMADDR. > MOD : Module name which has given SYM. > SYM[+offs] : Symbol+offset where the probe is inserted. > SYM%return : Return address of the symbol > MEMADDR : Address where the probe is inserted. > MAXACTIVE : Maximum number of instances of the specified function that > can be probed simultaneously, or 0 for the default value > Oops, that's my typo. Thank you! -- Masami Hiramatsu