From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
David Airlie <airlied@linux.ie>,
1882851@bugs.launchpad.net,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 1/2] drm/virtio: fix unblank
Date: Tue, 1 Sep 2020 09:34:33 +0200 [thread overview]
Message-ID: <20200901073433.GS2352366@phenom.ffwll.local> (raw)
In-Reply-To: <20200828112759.rmeeh5bonrewiqte@sirius.home.kraxel.org>
On Fri, Aug 28, 2020 at 01:27:59PM +0200, Gerd Hoffmann wrote:
> On Mon, Aug 24, 2020 at 09:24:40AM +0200, Jiri Slaby wrote:
> > On 18. 08. 20, 9:25, Gerd Hoffmann wrote:
> > > When going through a disable/enable cycle without changing the
> > > framebuffer the optimization added by commit 3954ff10e06e ("drm/virtio:
> > > skip set_scanout if framebuffer didn't change") causes the screen stay
> > > blank. Add a bool to force an update to fix that.
> > >
> > > v2: use drm_atomic_crtc_needs_modeset() (Daniel).
> > >
> > > Cc: 1882851@bugs.launchpad.net
> > > Fixes: 3954ff10e06e ("drm/virtio: skip set_scanout if framebuffer didn't change")
> > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >
> > Tested-by: Jiri Slaby <jirislaby@kernel.org>
>
> Ping. Need an ack or an review to merge this.
In case you still need that, on both patches:
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> thanks,
> Gerd
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-09-01 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200818072511.6745-1-kraxel@redhat.com>
2020-08-18 7:25 ` [PATCH 1/2] drm/virtio: fix unblank Gerd Hoffmann
2020-08-24 7:24 ` Jiri Slaby
2020-08-28 11:27 ` Gerd Hoffmann
2020-09-01 7:34 ` Daniel Vetter [this message]
2020-09-01 10:20 ` Daniel Vetter
2020-08-18 7:25 ` [PATCH 2/2] drm/virtio: drop virtio_gpu_output->enabled Gerd Hoffmann
2020-08-25 21:56 ` [PATCH] drm/virtio: fix unblank Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901073433.GS2352366@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=1882851@bugs.launchpad.net \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jirislaby@kernel.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox