From: Wolfram Sang <wsa@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Evan Nimmo <evan.nimmo@alliedtelesis.co.nz>,
jdelvare@suse.de, jarkko.nikula@linux.intel.com,
chris.packham@alliedtelesis.co.nz, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset
Date: Tue, 1 Sep 2020 10:46:19 +0200 [thread overview]
Message-ID: <20200901084619.GA897@ninjato> (raw)
In-Reply-To: <20200901082046.GO1891694@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
> > +/**
> > + * struct i2c_bus_settings - The configured i2c bus settings
> > + * @mode: Configured i2c bus mode (PCA9665)
> > + * @tlow: Configured SCL LOW period (PCA9665)
> > + * @thi: Configured SCL HIGH period (PCA9665)
> > + * @clock_freq: The configured clock frequency (PCA9564)
> > + */
> > +struct i2c_bus_settings {
> > + int mode;
> > + int tlow;
> > + int thi;
> > + int clock_freq;
> > +};
>
> This is a good candidate to have it in generic header for sake of the
> unification. Possible users:
>
> struct tegra_i2c_hw_feature
> struct cci_data::struct hw_params
Could be evaluated, but outside the scope of this patch, I think. This
is a bugfix, so a self-contained patch makes backporting a lot easier.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-09-01 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 0:57 [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset Evan Nimmo
2020-09-01 8:20 ` Andy Shevchenko
2020-09-01 8:46 ` Wolfram Sang [this message]
2020-09-01 8:50 ` Andy Shevchenko
2020-09-01 20:58 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901084619.GA897@ninjato \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=evan.nimmo@alliedtelesis.co.nz \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox