Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

Sedat Dilek
2020-09-01T08:46:33Z

On Tue, Sep 1, 2020 at 10:39 AM Willy Tarreau <w@1wt.eu> wrote:
>
> On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote:
> > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau <w@1wt.eu> wrote:
> > >
> > > +/*
> > > + * Generate some initially weak seeding values to allow
> > > + * the prandom_u32() engine to be started.
> > > + */
> > > +static int __init prandom_init_early(void)
> > > +{
> > > + int i;
> > > + unsigned long v0, v1, v2, v3;
> > > +
> > > + if (!arch_get_random_long(&v0))
> > > + v0 = jiffies;
> > > + if (!arch_get_random_long(&v1))
> > > + v0 = random_get_entropy();
> >
> > Shouldn't the above be:
> > v1 = random_get_entropy();
> > ?
>
> Very good catch, many thanks Yann! Now fixed in my local tree.
>

Thanks for offering a new patchset, Willy.

Will you push the updated patchset to your prandom Git - for easy fetching?

Thanks.

- Sedat -

[1] https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/