From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02ECFC433E2 for ; Tue, 1 Sep 2020 17:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C25A4206FA for ; Tue, 1 Sep 2020 17:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598979987; bh=5jkb5ORFpuR8LeeWXfWRUo27oTfjZ/NpAkPvzWqZAxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=U66Ok9U1wtWaSSCZSs3HqZvDIUYBAAq/V7uO33LPskw0lldtzIPW4M71goqwEEnI7 iezI6sgX0Z3mV4+Fs2nBmlOymYFUihMjgwKI/NDbxul26CJyd+KAoORtZ8cttrr83q flKQ+essmfKSZQ+jGwb1HmMKMu0gKVQ+daSny3dI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729466AbgIARF6 (ORCPT ); Tue, 1 Sep 2020 13:05:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:38066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729407AbgIAPTP (ORCPT ); Tue, 1 Sep 2020 11:19:15 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1FA8207D3; Tue, 1 Sep 2020 15:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598973552; bh=5jkb5ORFpuR8LeeWXfWRUo27oTfjZ/NpAkPvzWqZAxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IBTrlgKAeJTA/qveSLeTNkjivw6nmErzmixWerWcgFGXG/Eh/J6k9XyPNs3XPb0/c WoqsPS5AqE1E4AHXEohP1O8faw0ewoxQVOaONagcnVcQ8JFKyNDu68RQ6XQ2HVeW1d GVNVtpFAqK9GgyzcNOADVA9vtaAGRn03L31w0/DA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wolfram Sang , Wolfram Sang , Sasha Levin Subject: [PATCH 4.14 45/91] i2c: rcar: in slave mode, clear NACK earlier Date: Tue, 1 Sep 2020 17:10:19 +0200 Message-Id: <20200901150930.374217439@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901150928.096174795@linuxfoundation.org> References: <20200901150928.096174795@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wolfram Sang [ Upstream commit 914a7b3563b8fb92f976619bbd0fa3a4a708baae ] Currently, a NACK in slave mode is set/cleared when SCL is held low by the IP core right before the bit is about to be pushed out. This is too late for clearing and then a NACK from the previous byte is still used for the current one. Now, let's clear the NACK right after we detected the STOP condition following the NACK. Fixes: de20d1857dd6 ("i2c: rcar: add slave support") Signed-off-by: Wolfram Sang Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/busses/i2c-rcar.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index ed0f068109785..d5d0809a6283c 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -545,6 +545,7 @@ static bool rcar_i2c_slave_irq(struct rcar_i2c_priv *priv) /* master sent stop */ if (ssr_filtered & SSR) { i2c_slave_event(priv->slave, I2C_SLAVE_STOP, &value); + rcar_i2c_write(priv, ICSCR, SIE | SDBS); /* clear our NACK */ rcar_i2c_write(priv, ICSIER, SAR); rcar_i2c_write(priv, ICSSR, ~SSR & 0xff); } -- 2.25.1