From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33BCC433E6 for ; Tue, 1 Sep 2020 16:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CED5208CA for ; Tue, 1 Sep 2020 16:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598977702; bh=Z6vnP4+NxuzEHN1LLXN7z5Otdl9HCbvEaUVhEApV3pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZsSgEPmImtCTHbLLrsxxuCWrh24OL2V+f6zWlpqWZlmktXhNOAAq93iYv5oU13TKv TM6cYwj4/YWkXjQAsRKmqQWw/yTFgi/LgIZGlKOA0/ivdMVtYwxyemm/8NbMpH9ThX Nm2AP8vlXLgxewH3THk2Vf9euAi81Q2PDYWfeMbI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730861AbgIAQ2U (ORCPT ); Tue, 1 Sep 2020 12:28:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:35476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730839AbgIAPcC (ORCPT ); Tue, 1 Sep 2020 11:32:02 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CFDE21534; Tue, 1 Sep 2020 15:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598974321; bh=Z6vnP4+NxuzEHN1LLXN7z5Otdl9HCbvEaUVhEApV3pg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fqfwr9EqXMJY4AgjS+slX8K8xlMBvRbd+HmV4+PYX+k3DPTRiHQzKD0eBs56sZE7A aIedGo2IgSlRBYGfqJi7P2C2/LPQXJxSrsEj9zf2ve0IMfwybZQd5GmZkp9veQR5L4 w+pUzcHh1PSH3V+dy3zb0o3wKEmrrLsQksATYFXA= From: Krzysztof Kozlowski To: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/3] watchdog: rti: Simplify with dev_err_probe() Date: Tue, 1 Sep 2020 17:31:41 +0200 Message-Id: <20200901153141.18960-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200901153141.18960-1-krzk@kernel.org> References: <20200901153141.18960-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- It is unusual to expect deferred probe from pm_runtime_get()... --- drivers/watchdog/rti_wdt.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c index 705e8f7523e8..836319cbaca9 100644 --- a/drivers/watchdog/rti_wdt.c +++ b/drivers/watchdog/rti_wdt.c @@ -205,11 +205,8 @@ static int rti_wdt_probe(struct platform_device *pdev) return -ENOMEM; clk = clk_get(dev, NULL); - if (IS_ERR(clk)) { - if (PTR_ERR(clk) != -EPROBE_DEFER) - dev_err(dev, "failed to get clock\n"); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to get clock\n"); wdt->freq = clk_get_rate(clk); @@ -230,11 +227,8 @@ static int rti_wdt_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = pm_runtime_get_sync(dev); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "runtime pm failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "runtime pm failed\n"); platform_set_drvdata(pdev, wdt); -- 2.17.1