From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41989C433E2 for ; Tue, 1 Sep 2020 16:23:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 159F0206FA for ; Tue, 1 Sep 2020 16:23:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hgNGO+u9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731951AbgIAQXi (ORCPT ); Tue, 1 Sep 2020 12:23:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:57723 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728828AbgIAQXX (ORCPT ); Tue, 1 Sep 2020 12:23:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598977402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a32Yjr2eFkkA5dmrRXs0DH1p+/gxeW0TLToW+n8z3yc=; b=hgNGO+u9jxtRdhjzkNizg4FWAFEvrIFyxzrcOVMkeqjH1vtpMm+dXsFNT/7NUgHiG+Lsle l6m1yh4yLPNT8K7BOv3CYx/5o7Tmfn2DM76L48YT8g8vUkne+MiAqHJOFFxexyRz2hg93N bqv6AP+bZywIQEfK9OEH/L02wHY1NyY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-W7hirFWAM9WKO2i0NHJmjA-1; Tue, 01 Sep 2020 12:23:17 -0400 X-MC-Unique: W7hirFWAM9WKO2i0NHJmjA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B61110ABDAB; Tue, 1 Sep 2020 16:23:15 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.114]) by smtp.corp.redhat.com (Postfix) with SMTP id 9CA257EB9A; Tue, 1 Sep 2020 16:23:11 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 1 Sep 2020 18:23:14 +0200 (CEST) Date: Tue, 1 Sep 2020 18:23:10 +0200 From: Oleg Nesterov To: Christian Brauner Cc: linux-kernel@vger.kernel.org, Christian Brauner , "Peter Zijlstra (Intel)" , Ingo Molnar , Thomas Gleixner , "Eric W. Biederman" , Kees Cook , Sargun Dhillon , Aleksa Sarai , linux-kselftest@vger.kernel.org, Josh Triplett , Jens Axboe , linux-api@vger.kernel.org Subject: Re: [PATCH 1/4] pidfd: support PIDFD_NONBLOCK in pidfd_open() Message-ID: <20200901162309.GB4386@redhat.com> References: <20200831134551.1599689-1-christian.brauner@ubuntu.com> <20200831134551.1599689-2-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831134551.1599689-2-christian.brauner@ubuntu.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31, Christian Brauner wrote: > > --- /dev/null > +++ b/include/uapi/linux/pidfd.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > + > +#ifndef _UAPI_LINUX_PIDFD_H > +#define _UAPI_LINUX_PIDFD_H > + > +#include > +#include > + > +/* Flags for pidfd_open(). */ > +#define PIDFD_NONBLOCK O_NONBLOCK > + > +#endif /* _UAPI_LINUX_PIDFD_H */ Why? Can't we simply use O_NONBLOCK ? Oleg.