Re: [PATCH V3 4/6] perf tools: Add FIFO file names as alternative options to --control

Arnaldo Carvalho de Melo
2020-09-03T20:21:42Z

Em Wed, Sep 02, 2020 at 08:03:08PM +0300, Alexey Budankov escreveu:
>
> On 02.09.2020 13:57, Adrian Hunter wrote:
> > Enable the --control option to accept file names as an alternative to
> > file descriptors.
> >
> > Example:
> >
> > $ mkfifo perf.control
> > $ mkfifo perf.ack
> > $ cat perf.ack &
> > [1] 6808
> > $ perf record --control fifo:perf.control,perf.ack -- sleep 300 &
> > [2] 6810
> > $ echo disable > perf.control
> > $ Events disabled
> > ack
> >
> > $ echo enable > perf.control
> > $ Events enabled
> > ack
> >
> > $ echo disable > perf.control
> > $ Events disabled
> > ack
> >
> > $ kill %2
> > [ perf record: Woken up 4 times to write data ]
> > $ [ perf record: Captured and wrote 0.018 MB perf.data (7 samples) ]
> >
> > [1]- Done cat perf.ack
> > [2]+ Terminated perf record --control fifo:perf.control,perf.ack -- sleep 300
> > $
> >
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> > Acked-by: Jiri Olsa <jolsa@redhat.com>

Its great when things come with the exact sequence of commands to
test, the output, etc, keep it that way, please.

Thanks, tested, applied,

- Arnaldo