From: peterz@infradead.org
To: Nadav Amit <nadav.amit@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Nadav Amit <namit@vmware.com>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] x86/special_insn: reverse __force_order logic
Date: Wed, 2 Sep 2020 14:54:02 +0200 [thread overview]
Message-ID: <20200902125402.GG1362448@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200901161857.566142-1-namit@vmware.com>
On Tue, Sep 01, 2020 at 09:18:57AM -0700, Nadav Amit wrote:
> Unless I misunderstand the logic, __force_order should also be used by
> rdpkru() and wrpkru() which do not have dependency on __force_order. I
> also did not understand why native_write_cr0() has R/W dependency on
> __force_order, and why native_write_cr4() no longer has any dependency
> on __force_order.
There was a fairly large thread about this thing here:
https://lkml.kernel.org/r/20200527135329.1172644-1-arnd@arndb.de
I didn't keep up, but I think the general concensus was that it's
indeed a bit naf.
next prev parent reply other threads:[~2020-09-02 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 16:18 [PATCH] x86/special_insn: reverse __force_order logic Nadav Amit
2020-09-02 12:45 ` hpa
2020-09-02 12:54 ` peterz [this message]
2020-09-02 15:32 ` Nadav Amit
2020-09-02 16:56 ` peterz
2020-09-02 16:58 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902125402.GG1362448@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox