From: Dan Carpenter <dan.carpenter@oracle.com>
To: Antoni Przybylik <antoni.przybylik@wp.pl>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with a function v2
Date: Wed, 2 Sep 2020 16:58:32 +0300 [thread overview]
Message-ID: <20200902135832.GZ8299@kadam> (raw)
In-Reply-To: <20200902132559.61310-1-antoni.przybylik@wp.pl>
On Wed, Sep 02, 2020 at 03:25:59PM +0200, Antoni Przybylik wrote:
> This approach is more elegant and prevents some problems related to
> macros such as operator precedence in expanded expression.
> -------------------------------------------------------------------
> Changed return type to bool and removed inline sepcifier.
>
> Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
> ---
^^^
See this line.
No that doesn't work at all. Try applying your patch and reviewing the
git log. Look the the email archive to see how to send a v2 patch.
1) subject says [PATCH v2]
2) comments under the --- line
> drivers/staging/gdm724x/gdm_tty.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
regards,
dan carpenter
prev parent reply other threads:[~2020-09-02 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 13:25 [PATCH] staging: gdm724x: gdm_tty: replaced macro with a function v2 Antoni Przybylik
2020-09-02 13:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902135832.GZ8299@kadam \
--to=dan.carpenter@oracle.com \
--cc=antoni.przybylik@wp.pl \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox