Re: [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU

Alexander Shishkin
2020-09-18T12:46:44Z

Tingwei Zhang <tingwei@codeaurora.org> writes:

> @@ -63,6 +65,7 @@ static int __init stm_ftrace_init(void)
> {
> int ret;
>
> + stm_ftrace.data.nr_chans = num_possible_cpus();

Not a problem with this patch necesarily, but this made me realize that
.nr_chans may be larger than:

(1) what the policy permits,
(2) what the stm device can handle.

While (1) the user can fix in the policy, they won't be able to fix (2),
in which case they won't be able to use stm_ftrace at all. I'm thinking
if a link-time callback would be good enough.

Another thing is that .nr_chans needs to be a power of 2 at the moment.

Regards,
--
Alex