Re: [PATCH -rc 0/4] Protect from GCC garbage input in GCOV

Leon Romanovsky
2020-09-02T18:28:12Z

On Wed, Sep 02, 2020 at 11:24:50AM -0700, Linus Torvalds wrote:
> On Wed, Sep 2, 2020 at 10:52 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > Are you suggesting something like this?
> >
> > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > index 3110c77230c7..bc0e355f64aa 100644
> > --- a/kernel/gcov/Kconfig
> > +++ b/kernel/gcov/Kconfig
> > @@ -3,7 +3,7 @@ menu "GCOV-based kernel profiling"
> >
> > config GCOV_KERNEL
> > bool "Enable gcov-based kernel profiling"
> > - depends on DEBUG_FS
> > + depends on DEBUG_FS && (GCC_VERSION >= XXX && GCC_VERSION < YYY)
> > select CONSTRUCTORS if !UML
> > default n
> > help
>
> Yes. Except please don't mix it up with DEBUG_FS. Just add a new
> "depends on" line. They are separate issues.

Thanks, I'll do and resend.

>
> Linus