From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: shuo.a.liu@intel.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Yu Wang <yu1.wang@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Zhi Wang <zhi.a.wang@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v2 07/17] virt: acrn: Introduce an ioctl to set vCPU registers state
Date: Thu, 3 Sep 2020 15:03:25 +0200 [thread overview]
Message-ID: <20200903130325.GC2778029@kroah.com> (raw)
In-Reply-To: <20200903124201.17275-8-shuo.a.liu@intel.com>
On Thu, Sep 03, 2020 at 08:41:51PM +0800, shuo.a.liu@intel.com wrote:
> From: Shuo Liu <shuo.a.liu@intel.com>
>
> A virtual CPU of User VM has different context due to the different
> registers state. ACRN userspace needs to set the virtual CPU
> registers state (e.g. giving a initial registers state to a virtual
> BSP of a User VM).
>
> HSM provides an ioctl ACRN_IOCTL_SET_VCPU_REGS to do the virtual CPU
> registers state setting. The ioctl passes the registers state from ACRN
> userspace to the hypervisor directly.
>
> Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
> Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Cc: Zhi Wang <zhi.a.wang@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Yu Wang <yu1.wang@intel.com>
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/virt/acrn/hsm.c | 14 +++++++
> drivers/virt/acrn/hypercall.h | 13 +++++++
> include/uapi/linux/acrn.h | 71 +++++++++++++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
>
> diff --git a/drivers/virt/acrn/hsm.c b/drivers/virt/acrn/hsm.c
> index 6ec6aa9053d3..13df76d0206e 100644
> --- a/drivers/virt/acrn/hsm.c
> +++ b/drivers/virt/acrn/hsm.c
> @@ -12,6 +12,7 @@
> #define pr_fmt(fmt) "acrn: " fmt
> #define dev_fmt(fmt) "acrn: " fmt
>
> +#include <linux/io.h>
> #include <linux/miscdevice.h>
> #include <linux/mm.h>
> #include <linux/module.h>
> @@ -49,6 +50,7 @@ static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
> {
> struct acrn_vm *vm = filp->private_data;
> struct acrn_vm_creation *vm_param;
> + struct acrn_vcpu_regs *cpu_regs;
> int ret = 0;
>
> if (vm->vmid == ACRN_INVALID_VMID && cmd != ACRN_IOCTL_CREATE_VM) {
> @@ -96,6 +98,18 @@ static long acrn_dev_ioctl(struct file *filp, unsigned int cmd,
> case ACRN_IOCTL_DESTROY_VM:
> ret = acrn_vm_destroy(vm);
> break;
> + case ACRN_IOCTL_SET_VCPU_REGS:
> + cpu_regs = memdup_user((void __user *)ioctl_param,
> + sizeof(struct acrn_vcpu_regs));
> + if (IS_ERR(cpu_regs))
> + return PTR_ERR(cpu_regs);
> +
> + ret = hcall_set_vcpu_regs(vm->vmid, virt_to_phys(cpu_regs));
No sanity checking of any arguments?
Wow, fuzzers are going to have a fun time with your hypervisor, good
luck! :)
next prev parent reply other threads:[~2020-09-03 13:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 12:41 [PATCH v2 00/17] HSM driver for ACRN hypervisor shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 01/17] docs: acrn: Introduce ACRN shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 02/17] x86/acrn: Introduce acrn_{setup, remove}_intr_handler() shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 03/17] x86/acrn: Introduce an API to check if a VM is privileged shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 04/17] x86/acrn: Introduce hypercall interfaces shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 05/17] virt: acrn: Introduce ACRN HSM basic driver shuo.a.liu
2020-09-03 12:53 ` Greg Kroah-Hartman
2020-09-04 1:12 ` Liu, Shuo A
2020-09-03 12:41 ` [PATCH v2 06/17] virt: acrn: Introduce VM management interfaces shuo.a.liu
2020-09-03 13:02 ` Greg Kroah-Hartman
2020-09-04 4:29 ` Liu, Shuo A
2020-09-03 12:41 ` [PATCH v2 07/17] virt: acrn: Introduce an ioctl to set vCPU registers state shuo.a.liu
2020-09-03 13:03 ` Greg Kroah-Hartman [this message]
2020-09-04 4:39 ` Liu, Shuo A
2020-09-03 12:41 ` [PATCH v2 08/17] virt: acrn: Introduce EPT mapping management shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 09/17] virt: acrn: Introduce I/O request management shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 10/17] virt: acrn: Introduce PCI configuration space PIO accesses combiner shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 11/17] virt: acrn: Introduce interfaces for PCI device passthrough shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 12/17] virt: acrn: Introduce interrupt injection interfaces shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 13/17] virt: acrn: Introduce interfaces to query C-states and P-states allowed by hypervisor shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 14/17] virt: acrn: Introduce I/O ranges operation interfaces shuo.a.liu
2020-09-03 12:41 ` [PATCH v2 15/17] virt: acrn: Introduce ioeventfd shuo.a.liu
2020-09-03 12:42 ` [PATCH v2 16/17] virt: acrn: Introduce irqfd shuo.a.liu
2020-09-03 12:42 ` [PATCH v2 17/17] virt: acrn: Introduce an interface for Service VM to control vCPU shuo.a.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903130325.GC2778029@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=shuo.a.liu@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yu1.wang@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox