From: Oleg Nesterov <oleg@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: jason.wessel@windriver.com, daniel.thompson@linaro.org,
dianders@chromium.org, kgdb-bugreport@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH -next] kdb: Use newer api for tasklist scanning
Date: Thu, 3 Sep 2020 15:39:52 +0200 [thread overview]
Message-ID: <20200903133951.GG4386@redhat.com> (raw)
In-Reply-To: <20200831193435.22141-1-dave@stgolabs.net>
On 08/31, Davidlohr Bueso wrote:
>
> This kills the custom kdb_do_each_thread/kdb_while_each_thread
> calls used in kdb to iterate through all tasks. It is obsolete
> and racy to use tsk->thread_group, although in this particular
> case there is no concurrency so it doesn't matter. Still, lets
> trivially replace it for the newer one, maintaining semantics,
> of course.
>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
> ---
> kernel/debug/kdb/kdb_bt.c | 4 ++--
> kernel/debug/kdb/kdb_main.c | 8 ++++----
> kernel/debug/kdb/kdb_private.h | 4 ----
> 3 files changed, 6 insertions(+), 10 deletions(-)
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2020-09-03 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 19:34 [PATCH -next] kdb: Use newer api for tasklist scanning Davidlohr Bueso
2020-09-03 13:39 ` Oleg Nesterov [this message]
2020-09-07 13:46 ` Daniel Thompson
2020-09-07 20:03 ` Davidlohr Bueso
2020-09-07 20:32 ` [PATCH v2] " Davidlohr Bueso
2020-09-09 13:37 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903133951.GG4386@redhat.com \
--to=oleg@redhat.com \
--cc=daniel.thompson@linaro.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox