Re: [PATCH v2 2/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos4412 Odroid

Marek Szyprowski
2020-09-04T07:02:38Z

Hi Krzysztof,

On 03.09.2020 20:14, Krzysztof Kozlowski wrote:
> Commit 68605101460e ("ARM: dts: exynos: Add support for audio over HDMI
> for Odroid X/X2/U3") added assigned clocks under Clock Management Unit.
>
> However the dtschema expects "clocks" property if "assigned-clocks" are
> used. Add reference to input clock, the parent used in
> "assigned-clock-parents" to silence the dtschema warnings:
>
> arch/arm/boot/dts/exynos4412-odroidu3.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index ca3c78e0966c..9375df064076 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -120,6 +120,7 @@
> };
>
> &clock {
> + clocks = <&clock CLK_FOUT_EPLL>;

This should be one of xusbxti or xxti, because this is the proper input
clock for the clock controller. However in case of Exynos4, those clocks
needs much more cleanup. For the historical reasons, they don't use
generic 'fixed-clock' property, but the custom one and they are no
instantiated by clock framework, but the exynos4 clock driver...

> assigned-clocks = <&clock CLK_FOUT_EPLL>;
> assigned-clock-rates = <45158401>;
> };

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland