* [PATCH] mmc: renesas_sdhi: Drop local dma_parms
@ 2020-09-03 21:18 Robin Murphy
2020-09-04 6:03 ` Wolfram Sang
2020-09-07 10:07 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Robin Murphy @ 2020-09-03 21:18 UTC (permalink / raw)
To: wsa+renesas, ulf.hansson; +Cc: linux-mmc, linux-kernel
Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
for platform devices"), struct platform_device already provides a
dma_parms structure, so we can save allocating another one.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 32ab991544ef..8ee6b2b85ec2 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -336,10 +336,6 @@ static int renesas_sdhi_internal_dmac_probe(struct platform_device *pdev)
if (soc)
global_flags |= (unsigned long)soc->data;
- dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms), GFP_KERNEL);
- if (!dev->dma_parms)
- return -ENOMEM;
-
/* value is max of SD_SECCNT. Confirmed by HW engineers */
dma_set_max_seg_size(dev, 0xffffffff);
--
2.28.0.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: renesas_sdhi: Drop local dma_parms
2020-09-03 21:18 [PATCH] mmc: renesas_sdhi: Drop local dma_parms Robin Murphy
@ 2020-09-04 6:03 ` Wolfram Sang
2020-09-07 10:07 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-09-04 6:03 UTC (permalink / raw)
To: Robin Murphy; +Cc: ulf.hansson, linux-mmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Thu, Sep 03, 2020 at 10:18:06PM +0100, Robin Murphy wrote:
> Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
> for platform devices"), struct platform_device already provides a
> dma_parms structure, so we can save allocating another one.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Double-checked the mentioned commit above:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
No regression and same performance when checksumming a large file:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for the patch!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: renesas_sdhi: Drop local dma_parms
2020-09-03 21:18 [PATCH] mmc: renesas_sdhi: Drop local dma_parms Robin Murphy
2020-09-04 6:03 ` Wolfram Sang
@ 2020-09-07 10:07 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2020-09-07 10:07 UTC (permalink / raw)
To: Robin Murphy
Cc: Wolfram Sang, linux-mmc@vger.kernel.org,
Linux Kernel Mailing List
On Thu, 3 Sep 2020 at 23:18, Robin Murphy <robin.murphy@arm.com> wrote:
>
> Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms
> for platform devices"), struct platform_device already provides a
> dma_parms structure, so we can save allocating another one.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/renesas_sdhi_internal_dmac.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> index 32ab991544ef..8ee6b2b85ec2 100644
> --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -336,10 +336,6 @@ static int renesas_sdhi_internal_dmac_probe(struct platform_device *pdev)
> if (soc)
> global_flags |= (unsigned long)soc->data;
>
> - dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms), GFP_KERNEL);
> - if (!dev->dma_parms)
> - return -ENOMEM;
> -
> /* value is max of SD_SECCNT. Confirmed by HW engineers */
> dma_set_max_seg_size(dev, 0xffffffff);
>
> --
> 2.28.0.dirty
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-07 10:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03 21:18 [PATCH] mmc: renesas_sdhi: Drop local dma_parms Robin Murphy
2020-09-04 6:03 ` Wolfram Sang
2020-09-07 10:07 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox