From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alan Cox <alan@linux.intel.com>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: media: atomisp: Fix error path in lm3554_probe()
Date: Fri, 4 Sep 2020 09:35:07 +0300 [thread overview]
Message-ID: <20200904063506.GJ8321@kadam> (raw)
In-Reply-To: <20200903182502.709300-1-alex.dewar90@gmail.com>
On Thu, Sep 03, 2020 at 07:24:51PM +0100, Alex Dewar wrote:
> +
> + ret = atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH);
> + if (!ret)
> + return 0;
Ugh!!! This is a a special case of the "success handling instead of
failure handling" anti-pattern where the last condition in the function
is different. I just fixed a bug caused by this on Wed.
https://www.spinics.net/lists/netdev/msg680226.html
But it doesn't cause any problems here so whatever...
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2020-09-04 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 18:41 [PATCH] staging: media: atomisp: Fix error path in lm3554_probe() Alex Dewar
2020-09-03 12:11 ` Dan Carpenter
2020-09-03 15:48 ` Alex Dewar
2020-09-03 17:38 ` Dan Carpenter
2020-09-03 18:21 ` Alex Dewar
2020-09-03 18:24 ` [PATCH v2] " Alex Dewar
2020-09-04 6:35 ` Dan Carpenter [this message]
2020-09-19 19:50 ` Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904063506.GJ8321@kadam \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=alex.dewar90@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox