From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] RISC-V Fixes for 5.9-rc2
Date: Fri, 4 Sep 2020 09:31:09 +0100 [thread overview]
Message-ID: <20200904083109.GA9182@infradead.org> (raw)
In-Reply-To: <CAHk-=wi_tf4qsiBj5UD0GG3wz8Hi5NrHzqdrx+CwtfAY+_UiGg@mail.gmail.com>
On Fri, Aug 21, 2020 at 12:35:20PM -0700, Linus Torvalds wrote:
> On Fri, Aug 21, 2020 at 11:26 AM Palmer Dabbelt <palmer@dabbelt.com> wrote:
> >
> > * The CLINT driver has been split in two: one to handle the M-mode CLINT
> > (memory mapped and used on NOMMU systems) and one to handle the S-mode CLINT
> > (via SBI).
>
> This looks more like development than fixes.
>
> I guess I don't care deeply enough about it, but please don't do this.
Well, I care because this late pull requests completely breaks nommu
(nommu_virt_defconfig). More specifically commit 2bc3fc877aa9
("RISC-V: Remove CLINT related code from timer and arch") leas to this
spew when booting under qemu:
[ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0
[ 0.000000] riscv-intc: 64 local interrupts mapped
[ 0.000000] plic: interrupt-controller@c000000: mapped 53 interrupts with 2 handlers for 4 contexts.
[ 0.000000] Oops - illegal instruction [#1]
[ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.9.0-rc1-00003-g2bc3fc877aa9c4 #609
[ 0.000000] epc: 000000008000de78 ra : 000000008000ddaa sp : 0000000080187f40
[ 0.000000] gp : 00000000801a3aa8 tp : 000000008018bd40 t0 : 0000000000000019
[ 0.000000] t1 : 0000000000000018 t2 : 0000000000000001 s0 : 0000000080187f80
[ 0.000000] s1 : 0000000000000200 a0 : 000000008019b738 a1 : 0000000000000000
[ 0.000000] a2 : ffffffff80187f50 a3 : 0000000000000000 a4 : 0000000000000000
[ 0.000000] a5 : 0000000080169018 a6 : 0000000000000000 a7 : 00000000000001e4
[ 0.000000] s2 : 00000000801a40a8 s3 : 00000000801a4068 s4 : 000000008fc7c040
[ 0.000000] s5 : 00000000801a4038 s6 : 00000000801a4030 s7 : 0000000080012da0
[ 0.000000] s8 : 0000000000000000 s9 : 0000000000000000 s10: 0000000000000000
[ 0.000000] s11: 0000000000000000 t3 : 00000000801c40d8 t4 : 0000000000000068
[ 0.000000] t5 : 000000000000004c t6 : 0000000000000033
[ 0.000000] status: 0000000000001800 badaddr: 0000000000000000 cause: 0000000000000002
[ 0.000000] random: get_random_bytes called from 0x00000000800210c4 with crng_init=0
[ 0.000000] ---[ end trace 0000000000000000 ]---
[ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
[ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]---
next prev parent reply other threads:[~2020-09-04 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 18:26 [GIT PULL] RISC-V Fixes for 5.9-rc2 Palmer Dabbelt
2020-08-21 19:35 ` Linus Torvalds
2020-09-04 8:31 ` Christoph Hellwig [this message]
2020-09-04 9:42 ` Anup Patel
2020-09-04 9:46 ` Christoph Hellwig
2020-09-04 10:04 ` Anup Patel
[not found] ` <f1be6ee1-0802-82ca-ffdb-4c294925cd9a@kylinos.com.cn>
2020-09-04 13:00 ` Christoph Hellwig
2020-09-04 13:56 ` Anup Patel
2020-09-04 16:03 ` Christoph Hellwig
2020-09-04 16:14 ` Anup Patel
2020-08-21 22:05 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904083109.GA9182@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox