Re: [PATCH 4/4] device property: Move fwnode_connection_find_match() under drivers/base/property.c

Greg Kroah-Hartman
2020-09-07T09:04:02Z

On Fri, Sep 04, 2020 at 03:51:23PM +0300, Heikki Krogerus wrote:
> The function is now only a helper that searches the
> connection from device graph and then by checking if the
> supplied connection identifier matches a property that
> contains reference.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> .../driver-api/device_connection.rst | 43 --------
> drivers/base/Makefile | 2 +-
> drivers/base/devcon.c | 101 ------------------
> drivers/base/property.c | 73 +++++++++++++
> include/linux/device.h | 9 --
> include/linux/property.h | 14 +++
> 6 files changed, 88 insertions(+), 154 deletions(-)
> delete mode 100644 Documentation/driver-api/device_connection.rst

You also removed the documentation in this patch, which would have been
fine if you had mentioned it in the changelog text :(

I'll go queue up the first 3 patches of this series, can you split this
up into two?

thanks,

greg k-h