Re: [PATCH 06/13] dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

Vaittinen, Matti
2020-09-15T06:34:57Z

Hello All,

On Mon, 2020-09-14 at 16:44 -0600, Rob Herring wrote:
> On Fri, Sep 04, 2020 at 04:53:05PM +0200, Krzysztof Kozlowski wrote:
> > Add common properties appearing in DTSes (clock-names,
> > clock-output-names) to fix dtbs_check warnings like:
> >
> > arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
> > pmic@4b: 'clock-names', 'clock-output-names', do not match any
> > of the regexes: 'pinctrl-[0-9]+'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml | 6
> > ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837-
> > pmic.yaml
> > index 65018a019e1d..ecce0d5e3a95 100644
> > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
> > @@ -32,9 +32,15 @@ properties:
> > clocks:
> > maxItems: 1
> >
> > + clock-names:
> > + maxItems: 1
>
> Needs to define what the name is.

Someone once told me that "naming is hard".
Do we have some good common convention for 32K oscillator input naming?
Or should it just be dropped?

>
> > +
> > "#clock-cells":
> > const: 0
> >
> > + clock-output-names:
> > + maxItems: 1
>
> Ideally this one too, but we've been more flexible on it.

Data-sheet for BD71837 uses pin name "C32k_OUT". So maybe this would be
good?

BD71838 uses "bd71828-32k-out" . so we could also go with this same
convention and use "bd71837-32k-out". Or - we could take a risk and
*assume* typical use case for this clk (as this is typically used with
i.MX8 I'd guess the 32k is used for RTC) and name it accordingly.

Br,
Matti Vaittinen

--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland
SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~

Simon says - in Latin please.
"non cogito me" dixit Rene Descarte, deinde evanescavit

(Thanks for the translation Simon)