Re: [PATCH 1/8] rtc: rx8010: remove unnecessary parentheses

Alexandre Belloni
2020-09-04T15:32:43Z

On 04/09/2020 17:21:09+0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Remove parentheses whenever they guard a single line.

Those would be braces or curly brackets, not parentheses ;)

>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/rtc/rtc-rx8010.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c
> index fe010151ec8f..2faf5357a3a5 100644
> --- a/drivers/rtc/rtc-rx8010.c
> +++ b/drivers/rtc/rtc-rx8010.c
> @@ -181,9 +181,8 @@ static int rx8010_set_time(struct device *dev, struct rtc_time *dt)
> return ret;
>
> flagreg = i2c_smbus_read_byte_data(rx8010->client, RX8010_FLAG);
> - if (flagreg < 0) {
> + if (flagreg < 0)
> return flagreg;
> - }
>
> if (flagreg & RX8010_FLAG_VLF)
> ret = i2c_smbus_write_byte_data(rx8010->client, RX8010_FLAG,
> @@ -284,17 +283,15 @@ static int rx8010_set_alarm(struct device *dev, struct rtc_wkalrm *t)
> int err;
>
> flagreg = i2c_smbus_read_byte_data(client, RX8010_FLAG);
> - if (flagreg < 0) {
> + if (flagreg < 0)
> return flagreg;
> - }
>
> if (rx8010->ctrlreg & (RX8010_CTRL_AIE | RX8010_CTRL_UIE)) {
> rx8010->ctrlreg &= ~(RX8010_CTRL_AIE | RX8010_CTRL_UIE);
> err = i2c_smbus_write_byte_data(rx8010->client, RX8010_CTRL,
> rx8010->ctrlreg);
> - if (err < 0) {
> + if (err < 0)
> return err;
> - }
> }
>
> flagreg &= ~RX8010_FLAG_AF;
> --
> 2.26.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering