From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yuehaibing <yuehaibing@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, irogers@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] perf bench: fix return value check in do_run_multi_threaded()
Date: Fri, 4 Sep 2020 13:22:08 -0300 [thread overview]
Message-ID: <20200904162208.GS3495158@kernel.org> (raw)
In-Reply-To: <6815e565-c3a2-c7a2-f164-8d3c56f9c516@huawei.com>
Em Fri, Sep 04, 2020 at 09:25:02PM +0800, Yuehaibing escreveu:
> On 2020/9/4 2:55, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Sep 03, 2020 at 03:54:51PM -0300, Arnaldo Carvalho de Melo escreveu:
> >>>> Fixes: 13edc237200c ("perf bench: Add a multi-threaded synthesize benchmark")
> >>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >>> Thanks, applied, kudos for adding the Fixes: tag, appreciated!
> >> But...
> OOps, sorry for this, I'll pay attention next time.
Thanks!
- Arnaldo
> >>>> +++ b/tools/perf/bench/synthesize.c
> >>>> @@ -162,8 +162,8 @@ static int do_run_multi_threaded(struct target *target,
> >>>> init_stats(&event_stats);
> >>>> for (i = 0; i < multi_iterations; i++) {
> >>>> session = perf_session__new(NULL, false, NULL);
> >>>> - if (!session)
> >>>> - return -ENOMEM;
> >>>> + if (IS_ERR(session)) {
> >>>> + return PTR_ERR(session);
> >> This doesn't compile, so I take back that kudo ;-\
> >> I'm fixing this by removing that needless '{'.
prev parent reply other threads:[~2020-09-04 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 14:05 [PATCH -next] perf bench: fix return value check in do_run_multi_threaded() YueHaibing
2020-09-02 16:09 ` Ian Rogers
2020-09-03 18:53 ` Arnaldo Carvalho de Melo
2020-09-03 18:54 ` Arnaldo Carvalho de Melo
2020-09-03 18:55 ` Arnaldo Carvalho de Melo
2020-09-04 13:25 ` Yuehaibing
2020-09-04 16:22 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904162208.GS3495158@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox