From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Kajol Jain <kjain@linux.ibm.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] perf metric: Fix some memory leaks
Date: Fri, 4 Sep 2020 13:28:31 -0300 [thread overview]
Message-ID: <20200904162831.GU3495158@kernel.org> (raw)
In-Reply-To: <CAM9d7cgQAj-md=ZPKGD7iHEBYDnFqCfB1CO8moRih52MFoP6XQ@mail.gmail.com>
Em Fri, Sep 04, 2020 at 10:39:50PM +0900, Namhyung Kim escreveu:
> On Fri, Sep 4, 2020 at 1:02 PM Ian Rogers <irogers@google.com> wrote:
> >
> > On Thu, Sep 3, 2020 at 8:21 PM Namhyung Kim <namhyung@kernel.org> wrote:
> > >
> > > I found some memory leaks while reading the metric code. Some are
> > > real and others only occur in the error path.
> >
> > Thanks Namhyung! Is it possible to get test coverage?
> > Ian
>
> Not sure what you want..
>
> As I found it from code inspection I don't know if there's a test covering this.
>
> But as far as I can see, 2 of them are on the error path so maybe not easy
> to add a test, other one is called from perf list code, and the last one is on
> the normal code path so any test should cover it.
Humm, I assume all those fixes were for csets in a single Linux version,
right? Otherwise I think it'd be better to have a fix per Fixes tag, so
that they would go to the kernel sources where those bugs were fixed.
Thanks!
- Arnaldo
next prev parent reply other threads:[~2020-09-04 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 3:21 [PATCH] perf metric: Fix some memory leaks Namhyung Kim
2020-09-04 4:02 ` Ian Rogers
2020-09-04 13:39 ` Namhyung Kim
2020-09-04 16:28 ` Arnaldo Carvalho de Melo [this message]
2020-09-05 1:58 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904162831.GU3495158@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox